third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js - Issue 2157713002: DevTools: introduce View: a named widget with the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

index 3a631945bd4d6d1ffd3917befea2bc09bf04c6a1..cf08dd03de5407cdc693dae0fc5791b4ac3b3aff 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

@@ -4,12 +4,12 @@

/**

* @constructor

- * @extends {WebInspector.SidebarPane}

+ * @extends {WebInspector.View}

* @implements {WebInspector.TargetManager.Observer}

WebInspector.EventListenerBreakpointsSidebarPane = function()

{

- WebInspector.SidebarPane.call(this, WebInspector.UIString("Event Listener Breakpoints"));

+ WebInspector.View.call(this, WebInspector.UIString("Event Listener Breakpoints"));

this.registerRequiredCSS("components/breakpointsList.css");

this._eventListenerBreakpointsSetting = WebInspector.settings.createLocalSetting("eventListenerBreakpoints", []);

@@ -303,7 +303,7 @@ WebInspector.EventListenerBreakpointsSidebarPane.prototype = {

breakpointItem = this._findBreakpointItem(eventName, WebInspector.EventListenerBreakpointsSidebarPane.eventTargetAny);

if (!breakpointItem)

return;

- this.expandPane();

+ this.requestReveal();

breakpointItem.parent.element.expand();

breakpointItem.element.listItemElement.classList.add("breakpoint-hit");

this._highlightedElement = breakpointItem.element.listItemElement;

@@ -344,5 +344,5 @@ WebInspector.EventListenerBreakpointsSidebarPane.prototype = {

}

- __proto__: WebInspector.SidebarPane.prototype

+ __proto__: WebInspector.View.prototype

}