third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js - Issue 2157713002: DevTools: introduce View: a named widget with the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/module.json ('k') | third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

index bb16a44d51cc963c4a9e4d564376eb0ef16f889c..8a84df6ed782ecd1eadf0842e89f4e5545b51575 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

@@ -183,7 +183,7 @@ WebInspector.ExtensionButton.prototype = {

/**

* @constructor

- * @extends {WebInspector.SidebarPane}

+ * @extends {WebInspector.View}

* @param {!WebInspector.ExtensionServer} server

* @param {string} panelName

* @param {string} title

@@ -191,7 +191,8 @@ WebInspector.ExtensionButton.prototype = {

WebInspector.ExtensionSidebarPane = function(server, panelName, title, id)

{

- WebInspector.SidebarPane.call(this, title);

+ WebInspector.View.call(this, title);

+ this.element.classList.add("fill");

this._panelName = panelName;

this._server = server;

this._id = id;

@@ -314,5 +315,5 @@ WebInspector.ExtensionSidebarPane.prototype = {

callback();

- __proto__: WebInspector.SidebarPane.prototype

+ __proto__: WebInspector.View.prototype

}