Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
index efc191c978ce7809805e205621f80e7bc2472413..b8fccb5cbf8cf1c06353f392bb8e09f66185b2c2 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
@@ -29,11 +29,11 @@
/**
* @constructor
- * @extends {WebInspector.ThrottledWidget}
+ * @extends {WebInspector.ThrottledView}
*/
WebInspector.EventListenersWidget = function()
{
- WebInspector.ThrottledWidget.call(this);
+ WebInspector.ThrottledView.call(this, WebInspector.UIString("Event Listeners"));
this.element.classList.add("events-pane");
this._showForAncestorsSetting = WebInspector.settings.createSetting("showEventListenersForAncestors", true);
@@ -45,46 +45,38 @@ WebInspector.EventListenersWidget = function()
this._showFrameworkListenersSetting = WebInspector.settings.createSetting("showFrameowkrListeners", true);
this._showFrameworkListenersSetting.addChangeListener(this._showFrameworkListenersChanged.bind(this));
this._eventListenersView = new WebInspector.EventListenersView(this.element, this.update.bind(this));
- WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, this.update, this);
-}
-WebInspector.EventListenersWidget.DispatchFilterBy = {
- All : "All",
- Blocking : "Blocking",
- Passive : "Passive"
-}
-
-/**
- * @return {!WebInspector.ElementsSidebarViewWrapperPane}
- */
-WebInspector.EventListenersWidget.createSidebarWrapper = function()
-{
- var widget = new WebInspector.EventListenersWidget();
- var result = new WebInspector.ElementsSidebarViewWrapperPane(WebInspector.UIString("Event Listeners"), widget);
var refreshButton = new WebInspector.ToolbarButton(WebInspector.UIString("Refresh"), "refresh-toolbar-item");
- refreshButton.addEventListener("click", widget.update.bind(widget));
- result.toolbar().appendToolbarItem(refreshButton);
- result.toolbar().appendToolbarItem(new WebInspector.ToolbarCheckbox(WebInspector.UIString("Ancestors"), WebInspector.UIString("Show listeners on the ancestors"), widget._showForAncestorsSetting));
- var dispatchFilter = new WebInspector.ToolbarComboBox(widget._onDispatchFilterTypeChanged.bind(widget));
+ refreshButton.addEventListener("click", this.update.bind(this));
+ this.addToolbarItem(refreshButton);
+ this.addToolbarItem(new WebInspector.ToolbarCheckbox(WebInspector.UIString("Ancestors"), WebInspector.UIString("Show listeners on the ancestors"), this._showForAncestorsSetting));
+ var dispatchFilter = new WebInspector.ToolbarComboBox(this._onDispatchFilterTypeChanged.bind(this));
/**
* @param {string} name
* @param {string} value
+ * @this {WebInspector.EventListenersWidget}
*/
function addDispatchFilterOption(name, value)
{
var option = dispatchFilter.createOption(name, "", value);
- if (value === widget._dispatchFilterBySetting.get())
+ if (value === this._dispatchFilterBySetting.get())
dispatchFilter.select(option);
}
- addDispatchFilterOption(WebInspector.UIString("All"), WebInspector.EventListenersWidget.DispatchFilterBy.All);
- addDispatchFilterOption(WebInspector.UIString("Passive"), WebInspector.EventListenersWidget.DispatchFilterBy.Passive);
- addDispatchFilterOption(WebInspector.UIString("Blocking"), WebInspector.EventListenersWidget.DispatchFilterBy.Blocking);
+ addDispatchFilterOption.call(this, WebInspector.UIString("All"), WebInspector.EventListenersWidget.DispatchFilterBy.All);
+ addDispatchFilterOption.call(this, WebInspector.UIString("Passive"), WebInspector.EventListenersWidget.DispatchFilterBy.Passive);
+ addDispatchFilterOption.call(this, WebInspector.UIString("Blocking"), WebInspector.EventListenersWidget.DispatchFilterBy.Blocking);
dispatchFilter.setMaxWidth(200);
- result.toolbar().appendToolbarItem(dispatchFilter);
+ this.addToolbarItem(dispatchFilter);
+ this.addToolbarItem(new WebInspector.ToolbarCheckbox(WebInspector.UIString("Framework listeners"), WebInspector.UIString("Resolve event listeners bound with framework"), this._showFrameworkListenersSetting));
+
+ WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, this.update, this);
+}
- result.toolbar().appendToolbarItem(new WebInspector.ToolbarCheckbox(WebInspector.UIString("Framework listeners"), WebInspector.UIString("Resolve event listeners bound with framework"), widget._showFrameworkListenersSetting));
- return result;
+WebInspector.EventListenersWidget.DispatchFilterBy = {
+ All : "All",
+ Blocking : "Blocking",
+ Passive : "Passive"
}
WebInspector.EventListenersWidget._objectGroupName = "event-listeners-panel";
@@ -172,5 +164,5 @@ WebInspector.EventListenersWidget.prototype = {
{
},
- __proto__: WebInspector.ThrottledWidget.prototype
+ __proto__: WebInspector.ThrottledView.prototype
}

Powered by Google App Engine
This is Rietveld 408576698