Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
index 10e27f70aa8f5f7e22771b161868b033bb88deed..046eca1195e8d77c9fffdc0a7ca2c0cc1238a9a6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
@@ -4,13 +4,13 @@
/**
* @constructor
- * @extends {WebInspector.SidebarPane}
+ * @extends {WebInspector.View}
* @implements {WebInspector.TargetManager.Observer}
*/
WebInspector.ThreadsSidebarPane = function()
{
- WebInspector.SidebarPane.call(this, WebInspector.UIString("Threads"));
- this.setVisible(false);
+ WebInspector.View.call(this, WebInspector.UIString("Threads"));
+ this.requestSetVisible(false);
/** @type {!Map.<!WebInspector.DebuggerModel, !WebInspector.UIList.Item>} */
this._debuggerModelToListItems = new Map();
@@ -58,7 +58,7 @@ WebInspector.ThreadsSidebarPane.prototype = {
_updateVisibility: function()
{
this._wasVisibleAtLeastOnce = this._wasVisibleAtLeastOnce || this._debuggerModelToListItems.size > 1;
- this.setVisible(this._wasVisibleAtLeastOnce);
+ this.requestSetVisible(this._wasVisibleAtLeastOnce);
},
/**
@@ -148,5 +148,5 @@ WebInspector.ThreadsSidebarPane.prototype = {
},
- __proto__: WebInspector.SidebarPane.prototype
+ __proto__: WebInspector.View.prototype
}

Powered by Google App Engine
This is Rietveld 408576698