third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html - Issue 2157713002: DevTools: introduce View: a named widget with the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html ('k') | third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

diff --git a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

index 879ee2016e060d18ddbd4f875fa1d0c270974172..6f1f92e9540b3d7eac9a4491fe7da3587c2bc4c0 100644

--- a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

+++ b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

@@ -19,7 +19,7 @@ function initialize_extensionsSidebarTest()

{

var sidebar = InspectorTest._extensionSidebar(panelName);

InspectorTest.deprecatedRunAfterPendingDispatches(function() {

- sidebar.expandPane();

+ sidebar.requestReveal();

callback();

});

}

@@ -44,7 +44,8 @@ function extension_sidebarSetPage(panelName, nextTest)

dumpObject(sidebar);

function onShown(win)

{

- output("sidebar height " + win.document.documentElement.getBoundingClientRect().height);

+ if (panelName !== "elements")

+ output("sidebar height " + win.document.documentElement.getBoundingClientRect().height);

sidebar.onShown.removeListener(onShown);

nextTest();

}