third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js - Issue 2157713002: DevTools: introduce View: a named widget with the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

index 61e2137d40792383e7d7e1630e23f6393512eb7f..1a4f90811e064009d25b906eb56849a91c2ee317 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

@@ -68,9 +68,9 @@ WebInspector.RequestPreviewView.prototype = {

function handlePreviewView(view) {

this._previewView = view;

this._previewView.show(this.element);

- if (this._previewView instanceof WebInspector.VBoxWithToolbarItems) {

+ if (this._previewView instanceof WebInspector.View) {

var toolbar = new WebInspector.Toolbar("network-item-preview-toolbar", this.element);

- for (var item of /** @type {!WebInspector.VBoxWithToolbarItems} */ (this._previewView).toolbarItems())

+ for (var item of /** @type {!WebInspector.View} */ (this._previewView).toolbarItems())

toolbar.appendToolbarItem(item);

}

this.innerView = this._previewView;