Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 8ac38905b007a97699aef79ab1f7894db926e9a4..815b5f2fdc1879a03957980b0c93af009a88c013 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -348,7 +348,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
var element = this._breakpointElements[breakpointId];
if (!element)
return;
- this.expandPane();
+ this.requestReveal();
element.classList.add("breakpoint-hit");
this._highlightedElement = element;
},
@@ -436,24 +436,18 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
return proxy;
},
- onContentReady: function()
- {
- for (var i = 0; i < this._proxies.length; i++)
- this._proxies[i].onContentReady();
- },
-
__proto__: WebInspector.BreakpointsSidebarPaneBase.prototype
}
/**
* @constructor
- * @extends {WebInspector.SidebarPane}
+ * @extends {WebInspector.View}
* @param {!WebInspector.DOMBreakpointsSidebarPane} pane
* @param {!WebInspector.Panel} panel
*/
WebInspector.DOMBreakpointsSidebarPane.Proxy = function(pane, panel)
{
- WebInspector.SidebarPane.call(this, WebInspector.UIString("DOM Breakpoints"));
+ WebInspector.View.call(this, WebInspector.UIString("DOM Breakpoints"));
this.registerRequiredCSS("components/breakpointsList.css");
this._wrappedPane = pane;
@@ -461,22 +455,9 @@ WebInspector.DOMBreakpointsSidebarPane.Proxy = function(pane, panel)
}
WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype = {
- expandPane: function()
- {
- this._wrappedPane.expandPane();
- },
-
- onContentReady: function()
- {
- if (this._panel.isShowing())
- this._reattachBody();
-
- WebInspector.SidebarPane.prototype.onContentReady.call(this);
- },
-
wasShown: function()
{
- WebInspector.SidebarPane.prototype.wasShown.call(this);
+ WebInspector.View.prototype.wasShown.call(this);
this._reattachBody();
},
@@ -486,7 +467,7 @@ WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype = {
this._wrappedPane.show(this.element);
},
- __proto__: WebInspector.SidebarPane.prototype
+ __proto__: WebInspector.View.prototype
}
/**

Powered by Google App Engine
This is Rietveld 408576698