third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js - Issue 2157713002: DevTools: introduce View: a named widget with the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

index f53bbe76968ad1c295aa99083aee234813519c29..392e33fe0fa907af4e91516aaf5d6bbeb0aa50aa 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

@@ -17,7 +17,7 @@ WebInspector.XHRBreakpointsSidebarPane = function()

var addButton = new WebInspector.ToolbarButton(WebInspector.UIString("Add breakpoint"), "add-toolbar-item");

addButton.addEventListener("click", this._addButtonClicked.bind(this));

- this.toolbar().appendToolbarItem(addButton);

+ this.addToolbarItem(addButton);

this.emptyElement.addEventListener("contextmenu", this._emptyElementContextMenu.bind(this), true);

@@ -52,7 +52,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {

if (event)

event.consume();

- this.expandPane();

+ this.requestReveal();

var inputElementContainer = createElementWithClass("p", "breakpoint-condition");

inputElementContainer.textContent = WebInspector.UIString("Break when URL contains:");

@@ -217,7 +217,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {

var element = this._breakpointElements.get(url);

if (!element)

return;

- this.expandPane();

+ this.requestReveal();

element.classList.add("breakpoint-hit");

this._highlightedElement = element;