Change WTF::TemporaryChange to be an alias for AutoReset

Change WTF::TemporaryChange to be an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands. Since there's no benefit to a different
name, align the name as well, and clean up #include usage.

Inheriting from a typename alias confused MSVC, so the one instance
of that is changed to use a member instead.

Committed: https://crrev.com/bb8a6045d4557a81857321fc436b2e72930de689
Cr-Commit-Position: refs/heads/master@{#406285}

[jsbell, 2016-07-14 23:23:04]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-07-14 23:29:13]

jsbell@chromium.org changed reviewers:
+ esprehn@chromium.org

[jsbell, 2016-07-14 23:29:14]

Trivial WTF slimming. Worth doing? Should we rename to WTF::AutoReset at the
same time, since it'll touch the same number of files?

[esprehn, 2016-07-14 23:59:51]

Sigh, the coding style out in base not allowing non-const ref adds so much line
noise. Yeah if you want to rename it you might as well do it now.

lgtm w/ or wo/ the rename as you see fit. :)

[haraken, 2016-07-15 00:04:42]

On 2016/07/14 23:59:51, esprehn wrote:
> Sigh, the coding style out in base not allowing non-const ref adds so much
line
> noise. Yeah if you want to rename it you might as well do it now.
> 
> lgtm w/ or wo/ the rename as you see fit. :)

Agreed. LGTM.

[commit-bot: I haz the power, 2016-07-15 00:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:05:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuta Kitamura, 2016-07-15 03:04:40]

yutak@chromium.org changed reviewers:
+ yutak@chromium.org

[Yuta Kitamura, 2016-07-15 03:04:41]

LGTM

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/TemporaryChange.h (right):

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/TemporaryChange.h:36: using TemporaryChange =
typename base::AutoReset<T>;
A compiler in my brain tells this "typename" is unnecessary. But it comes
with no guarantee ;)

[Yuta Kitamura, 2016-07-15 03:09:25]

But MSVC errors are still mysterious. It's known to have a
bug around template aliases (template using), and you might
be hitting this. I'm not aware of any workarounds.

[tzik, 2016-07-15 04:25:01]

tzik@chromium.org changed reviewers:
+ tzik@chromium.org

[tzik, 2016-07-15 04:25:02]

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleEngine.h (right):

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleEngine.h:67: :
TemporaryChange<bool>(&engine.m_ignorePendingStylesheets, true)
MSVC seems to fail to call the parent constructor through the type alias.
Could you avoid inheriting TemporaryChange and move it to a member?

[jsbell, 2016-07-18 18:42:35]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-07-18 18:42:37]

Thanks, all! Giving tzik's inheriting->member suggestion a whirl.

I'll do a follow-up PS renaming the type, assuming this passes the bots...

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleEngine.h (right):

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleEngine.h:67: :
TemporaryChange<bool>(&engine.m_ignorePendingStylesheets, true)
On 2016/07/15 04:25:02, tzik wrote:
> MSVC seems to fail to call the parent constructor through the type alias.
> Could you avoid inheriting TemporaryChange and move it to a member?

I'll give that a try. (Seems cleaner anyway?)

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/TemporaryChange.h (right):

https://codereview.chromium.org/2151933003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/TemporaryChange.h:36: using TemporaryChange =
typename base::AutoReset<T>;
On 2016/07/15 03:04:41, Yuta Kitamura wrote:
> A compiler in my brain tells this "typename" is unnecessary. But it comes
> with no guarantee ;)

Copy/pasta. Will remove.

[jsbell, 2016-07-18 20:41:10]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 20:41:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:10:05]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-07-18 22:20:35]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 22:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-07-19 00:11:22]

Description was changed from

==========
Make WTF::TemporaryChange an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands.
==========

to

==========
Change WTF::TemporaryChange to be an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands. Since there's no benefit to a different
name, align the name as well, and clean up #include usage.

Inheriting from a typename alias confused MSVC, so the one instance
of that is changed to use a member instead.
==========

[commit-bot: I haz the power, 2016-07-19 02:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:08:10]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-07-19 02:09:29]

lgtm

[jsbell, 2016-07-19 15:55:20]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-07-19 15:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, esprehn@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2151933003/#ps40001
(title: "TemporaryChange -> AutoReset")

[commit-bot: I haz the power, 2016-07-19 15:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-07-19 15:56:36]


I'm currently out of the office until July 21 (holidays). I will not be checking
my email regularly, expect delays in my answers.

For Crosswalk related topics please contact <francesco.balestrieri@intel.com>

For Web Platform related topics please contact
<kenneth.r.christiansen@intel.com> or <barbara.hochgesang@intel.com>

For Crosswalk infrastructure please contact <raphael.kubo.da.costa@intel.com>

Urgent topic : +1 9717708015

[commit-bot: I haz the power, 2016-07-19 16:03:12]

Description was changed from

==========
Change WTF::TemporaryChange to be an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands. Since there's no benefit to a different
name, align the name as well, and clean up #include usage.

Inheriting from a typename alias confused MSVC, so the one instance
of that is changed to use a member instead.
==========

to

==========
Change WTF::TemporaryChange to be an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands. Since there's no benefit to a different
name, align the name as well, and clean up #include usage.

Inheriting from a typename alias confused MSVC, so the one instance
of that is changed to use a member instead.
==========

[commit-bot: I haz the power, 2016-07-19 16:03:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 16:03:18]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 16:05:20]

Description was changed from

==========
Change WTF::TemporaryChange to be an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands. Since there's no benefit to a different
name, align the name as well, and clean up #include usage.

Inheriting from a typename alias confused MSVC, so the one instance
of that is changed to use a member instead.
==========

to

==========
Change WTF::TemporaryChange to be an alias for base::AutoReset

The behavior is the same, except that base::AutoReset takes a pointer
whereas WTF::TemporaryChange took a non-const ref, so callers get
sprinkled with ampersands. Since there's no benefit to a different
name, align the name as well, and clean up #include usage.

Inheriting from a typename alias confused MSVC, so the one instance
of that is changed to use a member instead.

Committed: https://crrev.com/bb8a6045d4557a81857321fc436b2e72930de689
Cr-Commit-Position: refs/heads/master@{#406285}
==========

[commit-bot: I haz the power, 2016-07-19 16:05:23]

Patchset 3 (id:??) landed as
https://crrev.com/bb8a6045d4557a81857321fc436b2e72930de689
Cr-Commit-Position: refs/heads/master@{#406285}