third_party/WebKit/Source/platform/heap/HeapPage.cpp - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/HeapPage.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TemporaryChange -> AutoReset Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/ScriptForbiddenScope.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/HeapPage.cpp

diff --git a/third_party/WebKit/Source/platform/heap/HeapPage.cpp b/third_party/WebKit/Source/platform/heap/HeapPage.cpp

index b7da90ae531826a4df862d5d38dc523e66d1271c..b91b7597e8e65e34497e8eda1ad2a1fafbb62481 100644

--- a/third_party/WebKit/Source/platform/heap/HeapPage.cpp

+++ b/third_party/WebKit/Source/platform/heap/HeapPage.cpp

@@ -45,10 +45,10 @@

#include "platform/web_process_memory_dump.h"

#include "public/platform/Platform.h"

#include "wtf/Assertions.h"

+#include "wtf/AutoReset.h"

#include "wtf/ContainerAnnotations.h"

#include "wtf/CurrentTime.h"

#include "wtf/LeakAnnotations.h"

-#include "wtf/TemporaryChange.h"

#include "wtf/allocator/PageAllocator.h"

#include "wtf/allocator/Partitions.h"

@@ -692,7 +692,7 @@ bool NormalPageArena::shrinkObject(HeapObjectHeader* header, size_t newSize)

Address NormalPageArena::lazySweepPages(size_t allocationSize, size_t gcInfoIndex)

{

ASSERT(!hasCurrentAllocationArea());

- TemporaryChange<bool> isLazySweeping(m_isLazySweeping, true);

+ AutoReset<bool> isLazySweeping(&m_isLazySweeping, true);

Address result = nullptr;

while (m_firstUnsweptPage) {

BasePage* page = m_firstUnsweptPage;