third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TemporaryChange -> AutoReset Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTitleElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp

diff --git a/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp b/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp

index 76d1c9bb45fbe7165dbc5fc3d6b88b87f345f834..8ebef6e81b7e732db3a7874655a6a14ad674b807 100644

--- a/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp

+++ b/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp

@@ -5,7 +5,7 @@

#include "core/frame/PlatformEventDispatcher.h"

#include "core/frame/PlatformEventController.h"

-#include "wtf/TemporaryChange.h"

+#include "wtf/AutoReset.h"

namespace blink {

@@ -48,7 +48,7 @@ void PlatformEventDispatcher::notifyControllers()

return;

{

- TemporaryChange<bool> changeIsDispatching(m_isDispatching, true);

+ AutoReset<bool> changeIsDispatching(&m_isDispatching, true);

// HashSet m_controllers can be updated during an iteration, and it stops the iteration.

// Thus we store it into a Vector to access all elements.

HeapVector<Member<PlatformEventController>> snapshotVector;