third_party/WebKit/Source/platform/LifecycleNotifier.h - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LifecycleNotifier.h

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TemporaryChange -> AutoReset Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/EventDispatchForbiddenScope.h ('k') | third_party/WebKit/Source/platform/ScriptForbiddenScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/LifecycleNotifier.h

diff --git a/third_party/WebKit/Source/platform/LifecycleNotifier.h b/third_party/WebKit/Source/platform/LifecycleNotifier.h

index 72d6680d78628c5f095463ca3978c2cf48b343ca..11f3e658182ce23519528992be0c0aaad4e342b9 100644

--- a/third_party/WebKit/Source/platform/LifecycleNotifier.h

+++ b/third_party/WebKit/Source/platform/LifecycleNotifier.h

@@ -28,8 +28,8 @@

#define LifecycleNotifier_h

#include "platform/heap/Handle.h"

+#include "wtf/AutoReset.h"

#include "wtf/HashSet.h"

-#include "wtf/TemporaryChange.h"

namespace blink {

@@ -94,7 +94,7 @@ template<typename T, typename Observer>

inline void LifecycleNotifier<T, Observer>::notifyContextDestroyed()

{

// Observer unregistration is allowed, but effectively a no-op.

- TemporaryChange<IterationState> scope(m_iterationState, AllowingRemoval);

+ AutoReset<IterationState> scope(&m_iterationState, AllowingRemoval);

ObserverSet observers;

m_observers.swap(observers);

for (Observer* observer : observers) {