Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/wtf/TemporaryChange.h

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef TemporaryChange_h 26 #ifndef TemporaryChange_h
27 #define TemporaryChange_h 27 #define TemporaryChange_h
28 28
29 #include "wtf/Noncopyable.h" 29 #include "base/auto_reset.h"
30 30
31 namespace WTF { 31 namespace WTF {
32 32
33 // TemporaryChange<> is useful for setting a variable to a new value only within a 33 // WTF::TemporaryChange is base::AutoReset. See base/auto_reset.h for documentat ion.
34 // particular scope. An TemporaryChange<> object changes a variable to its origi nal
35 // value upon destruction, making it an alternative to writing "var = false;"
36 // or "var = oldVal;" at all of a block's exit points.
37 //
38 // This should be obvious, but note that an TemporaryChange<> instance should ha ve a
39 // shorter lifetime than its scopedVariable, to prevent invalid memory writes
40 // when the TemporaryChange<> object is destroyed.
41 34
42 template<typename T> 35 template <typename T>
43 class TemporaryChange { 36 using TemporaryChange = typename base::AutoReset<T>;
Yuta Kitamura 2016/07/15 03:04:41 A compiler in my brain tells this "typename" is un
jsbell 2016/07/18 18:42:37 Copy/pasta. Will remove.
44 WTF_MAKE_NONCOPYABLE(TemporaryChange);
45 public:
46 TemporaryChange(T& scopedVariable, T newValue)
47 : m_scopedVariable(scopedVariable)
48 , m_originalValue(scopedVariable)
49 {
50 m_scopedVariable = newValue;
51 }
52
53 ~TemporaryChange()
54 {
55 m_scopedVariable = m_originalValue;
56 }
57
58
59 private:
60 T& m_scopedVariable;
61 T m_originalValue;
62 };
63 37
64 } // namespace WTF 38 } // namespace WTF
65 39
66 using WTF::TemporaryChange; 40 using WTF::TemporaryChange;
67 41
68 #endif 42 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698