third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TemporaryChange -> AutoReset Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTitleElement.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

index 5c38a5cf8a10f2ea66bfa5ee2806dfe07d5bf175..7525edd62e16fbe3035566342107cef8a1cda067 100644

--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

@@ -66,9 +66,9 @@

#include "platform/network/ResourceRequest.h"

#include "platform/network/ResourceResponse.h"

#include "platform/weborigin/SecurityOrigin.h"

+#include "wtf/AutoReset.h"

#include "wtf/PtrUtil.h"

#include "wtf/StringExtras.h"

-#include "wtf/TemporaryChange.h"

#include "wtf/Threading.h"

#include "wtf/Vector.h"

#include "wtf/text/UTF8.h"

@@ -870,7 +870,7 @@ void XMLDocumentParser::doWrite(const String& parseString)

// string.

if (parseString.length()) {

XMLDocumentParserScope scope(document());

- TemporaryChange<bool> encodingScope(m_isCurrentlyParsing8BitChunk, parseString.is8Bit());

+ AutoReset<bool> encodingScope(&m_isCurrentlyParsing8BitChunk, parseString.is8Bit());

parseChunk(context->context(), parseString);

// JavaScript (which may be run under the parseChunk callstack) may