third_party/WebKit/Source/core/html/HTMLTitleElement.cpp - Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TemporaryChange -> AutoReset Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp b/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

index 29b510603a4f21a4f81b7547c16bb795c1ce5353..9883e755aa6940fcf25f144ba079f24be3e7697e 100644

--- a/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

@@ -29,6 +29,7 @@

#include "core/dom/Text.h"

#include "core/style/ComputedStyle.h"

#include "core/style/StyleInheritedData.h"

+#include "wtf/AutoReset.h"

#include "wtf/text/StringBuilder.h"

namespace blink {

@@ -83,7 +84,7 @@ void HTMLTitleElement::setText(const String &value)

{

// Avoid calling Document::setTitleElement() during intermediate steps.

- TemporaryChange<bool> inhibitTitleUpdateScope(m_ignoreTitleUpdatesWhenChildrenChange, !value.isEmpty());

+ AutoReset<bool> inhibitTitleUpdateScope(&m_ignoreTitleUpdatesWhenChildrenChange, !value.isEmpty());

removeChildren(OmitSubtreeModifiedEvent);

}