Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

Issue 2151933003: Change WTF::TemporaryChange to be an alias for AutoReset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TemporaryChange -> AutoReset Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved.
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 10 matching lines...) Expand all
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "core/editing/commands/UndoStack.h" 27 #include "core/editing/commands/UndoStack.h"
28 28
29 #include "core/dom/ContainerNode.h" 29 #include "core/dom/ContainerNode.h"
30 #include "core/editing/commands/UndoStep.h" 30 #include "core/editing/commands/UndoStep.h"
31 #include "wtf/TemporaryChange.h" 31 #include "wtf/AutoReset.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 // Arbitrary depth limit for the undo stack, to keep it from using 35 // Arbitrary depth limit for the undo stack, to keep it from using
36 // unbounded memory. This is the maximum number of distinct undoable 36 // unbounded memory. This is the maximum number of distinct undoable
37 // actions -- unbroken stretches of typed characters are coalesced 37 // actions -- unbroken stretches of typed characters are coalesced
38 // into a single action. 38 // into a single action.
39 static const size_t maximumUndoStackDepth = 1000; 39 static const size_t maximumUndoStackDepth = 1000;
40 40
41 UndoStack::UndoStack() 41 UndoStack::UndoStack()
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 } 84 }
85 85
86 void UndoStack::redo() 86 void UndoStack::redo()
87 { 87 {
88 if (canRedo()) { 88 if (canRedo()) {
89 UndoStepStack::iterator back = --m_redoStack.end(); 89 UndoStepStack::iterator back = --m_redoStack.end();
90 UndoStep* step(back->get()); 90 UndoStep* step(back->get());
91 m_redoStack.remove(back); 91 m_redoStack.remove(back);
92 92
93 DCHECK(!m_inRedo); 93 DCHECK(!m_inRedo);
94 TemporaryChange<bool> redoScope(m_inRedo, true); 94 AutoReset<bool> redoScope(&m_inRedo, true);
95 step->reapply(); 95 step->reapply();
96 // reapply will call us back to push this command onto the undo stack. 96 // reapply will call us back to push this command onto the undo stack.
97 } 97 }
98 } 98 }
99 99
100 void UndoStack::clear() 100 void UndoStack::clear()
101 { 101 {
102 m_undoStack.clear(); 102 m_undoStack.clear();
103 m_redoStack.clear(); 103 m_redoStack.clear();
104 } 104 }
105 105
106 DEFINE_TRACE(UndoStack) 106 DEFINE_TRACE(UndoStack)
107 { 107 {
108 visitor->trace(m_undoStack); 108 visitor->trace(m_undoStack);
109 visitor->trace(m_redoStack); 109 visitor->trace(m_redoStack);
110 } 110 }
111 111
112 } // namespace blink 112 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionController.cpp ('k') | third_party/WebKit/Source/core/fetch/MemoryCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698