Introduce GLStubApi

Introduce GLStubApi

The mock GL bindings are useful, but they are very complex to setup and use
(gmock), and too slow for some uses (e.g. a fuzzer), and painful to maintain as
the decoder code evolves.

This CL introduces a GLStubApi as an alternative:
- GLStubApi hooks at the GLApi level rather than the DriverGL level, that is, it
implements a full interface rather than individual functions looked up through
GetProcAddress. It is simpler to override.
- the CL implements an auto-generated GLStubApiBase which only has trivial
functions, as well as a more concrete GLStubApi that implements enough to
initialize and run a GLES2Decoder.
- GpuChannelTest was changed to use the GLStubApi

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/aa595d83c0f482773418fd441ffa0f23fd62d4ef
Cr-Commit-Position: refs/heads/master@{#405276}

[piman, 2016-07-11 20:15:07]

Description was changed from

==========
Introduce GLStubApi

The mock GL bindings are useful, but they are very complex to setup and use
(gmock), and too slow for some uses (e.g. a fuzzer), and painful to maintain as
the decoder code evolves.

This CL introduces a GLStubApi as an alternative:
- GLStubApi hooks at the GLApi level rather than the DriverGL level, that is, it
implements a full interface rather than individual functions looked up through
GetProcAddress. It is simpler to override.
- the CL implements an auto-generated GLStubApiBase which only has trivial
functions, as well as a more concrete GLStubApi that implements enough to
initialize and run a GLES2Decoder.
- GpuChannelTest was changed to use the GLStubApi

BUG=None
==========

to

==========
Introduce GLStubApi

The mock GL bindings are useful, but they are very complex to setup and use
(gmock), and too slow for some uses (e.g. a fuzzer), and painful to maintain as
the decoder code evolves.

This CL introduces a GLStubApi as an alternative:
- GLStubApi hooks at the GLApi level rather than the DriverGL level, that is, it
implements a full interface rather than individual functions looked up through
GetProcAddress. It is simpler to override.
- the CL implements an auto-generated GLStubApiBase which only has trivial
functions, as well as a more concrete GLStubApi that implements enough to
initialize and run a GLES2Decoder.
- GpuChannelTest was changed to use the GLStubApi

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-07-11 20:27:01]

piman@chromium.org changed reviewers:
+ sievers@chromium.org

[piman, 2016-07-11 20:27:02]

sievers: PTAL at another prereq for the fuzzer - mock bindings are way too slow
(5-10x)... I think this can make a lot of the testing simpler/easier too (see
changed test).

[piman, 2016-07-11 21:23:04]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 21:23:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 22:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 22:26:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[no sievers, 2016-07-11 22:42:42]

lgtm, much simpler to use indeed.

https://codereview.chromium.org/2136223002/diff/1/ui/gl/gl_gl_api_implementat...
File ui/gl/gl_gl_api_implementation.cc (right):

https://codereview.chromium.org/2136223002/diff/1/ui/gl/gl_gl_api_implementat...
ui/gl/gl_gl_api_implementation.cc:386: SetGLApi(g_stub_gl ? g_stub_gl : g_gl);
What uses GLContextStub in a way that this has to fall back to the real API?

[piman, 2016-07-11 23:57:27]

https://codereview.chromium.org/2136223002/diff/1/ui/gl/gl_gl_api_implementat...
File ui/gl/gl_gl_api_implementation.cc (right):

https://codereview.chromium.org/2136223002/diff/1/ui/gl/gl_gl_api_implementat...
ui/gl/gl_gl_api_implementation.cc:386: SetGLApi(g_stub_gl ? g_stub_gl : g_gl);
On 2016/07/11 22:42:41, sievers wrote:
> What uses GLContextStub in a way that this has to fall back to the real API?

The mock bindings use RealGLApi, but hooking GetProcAddress to return a
trampoline function that calls into the MockGLInterface. I suspect it would be
possible to change the mock bindings to also hook directly at the GLApi level
instead (a little saner), but there is so much test code that relies on the
current hookup that I think it wouldn't be productive to try to migrate it
wholesale.

[piman, 2016-07-11 23:59:35]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:00:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 00:54:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:54:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[piman, 2016-07-12 03:20:01]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 03:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 04:52:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:52:38]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-12 14:52:13]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:53:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:40:31]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[piman, 2016-07-12 21:09:24]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 23:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 23:47:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-12 23:54:30]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-12 23:57:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 00:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:38:54]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-13 18:28:24]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-13 18:28:25]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-13 18:28:32]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:29:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:33:38]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names without "master." prefix is deprecated:
tryserver.chromium.linux, tryserver.chromium.mac, tryserver.chromium.win. For
more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-13 20:26:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 20:27:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 20:29:00]

Description was changed from

==========
Introduce GLStubApi

The mock GL bindings are useful, but they are very complex to setup and use
(gmock), and too slow for some uses (e.g. a fuzzer), and painful to maintain as
the decoder code evolves.

This CL introduces a GLStubApi as an alternative:
- GLStubApi hooks at the GLApi level rather than the DriverGL level, that is, it
implements a full interface rather than individual functions looked up through
GetProcAddress. It is simpler to override.
- the CL implements an auto-generated GLStubApiBase which only has trivial
functions, as well as a more concrete GLStubApi that implements enough to
initialize and run a GLES2Decoder.
- GpuChannelTest was changed to use the GLStubApi

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Introduce GLStubApi

The mock GL bindings are useful, but they are very complex to setup and use
(gmock), and too slow for some uses (e.g. a fuzzer), and painful to maintain as
the decoder code evolves.

This CL introduces a GLStubApi as an alternative:
- GLStubApi hooks at the GLApi level rather than the DriverGL level, that is, it
implements a full interface rather than individual functions looked up through
GetProcAddress. It is simpler to override.
- the CL implements an auto-generated GLStubApiBase which only has trivial
functions, as well as a more concrete GLStubApi that implements enough to
initialize and run a GLES2Decoder.
- GpuChannelTest was changed to use the GLStubApi

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/aa595d83c0f482773418fd441ffa0f23fd62d4ef
Cr-Commit-Position: refs/heads/master@{#405276}
==========

[commit-bot: I haz the power, 2016-07-13 20:29:01]

Patchset 1 (id:??) landed as
https://crrev.com/aa595d83c0f482773418fd441ffa0f23fd62d4ef
Cr-Commit-Position: refs/heads/master@{#405276}