[ic] Split megamorphic stub cache in two caches (for loads and for stores).

[ic] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for megamorphic
stub caches and therefore the unused ICState field can be finally removed from flags.

BUG=chromium:618701
Committed: https://crrev.com/b449dc0b6fc33e92563f1a31cd523f02aa31baae
Cr-Commit-Position: refs/heads/master@{#37708}

[Igor Sheludko, 2016-07-07 15:23:52]

Description was changed from

==========
[runtime] Isolate::stub_cache() is split into Isolate::load_stub_cache() and
Isolate::store_stub_cache().

After this CL we can avoid using Code::flags in hash computations for
megamorphic stub caches.

BUG=chromium:618701
==========

to

==========
[runtime] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701
==========

[Igor Sheludko, 2016-07-07 15:24:19]

Description was changed from

==========
[runtime] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701
==========

to

==========
[ic] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701
==========

[Igor Sheludko, 2016-07-07 15:32:13]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-07-07 15:33:48]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-07-07 15:37:07]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 15:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 15:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 15:41:48]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/10202)

[Igor Sheludko, 2016-07-07 15:47:47]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 15:47:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 15:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 15:54:48]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[Igor Sheludko, 2016-07-07 22:04:11]

Patchset #2 (id:60001) has been deleted

[Igor Sheludko, 2016-07-07 22:04:26]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-07-07 22:04:41]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 22:04:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 22:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 22:37:45]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-07-07 23:02:25]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-07-07 23:02:26]

PTAL

https://codereview.chromium.org/2123983004/diff/80001/src/type-info.cc
File src/type-info.cc (left):

https://codereview.chromium.org/2123983004/diff/80001/src/type-info.cc#oldcod...
src/type-info.cc:283: Code::Flags flags =
Code::ComputeHandlerFlags(Code::LOAD_IC);
I wonder, why don't we do RemoveHolderFromFlags() here?

https://codereview.chromium.org/2123983004/diff/80001/src/type-info.cc#oldcod...
src/type-info.cc:309: Code::Flags flags =
Code::ComputeHandlerFlags(Code::STORE_IC);
... and here?

[Igor Sheludko, 2016-07-12 11:13:46]

https://codereview.chromium.org/2123983004/diff/80001/src/type-info.cc
File src/type-info.cc (left):

https://codereview.chromium.org/2123983004/diff/80001/src/type-info.cc#oldcod...
src/type-info.cc:283: Code::Flags flags =
Code::ComputeHandlerFlags(Code::LOAD_IC);
On 2016/07/07 23:02:25, Igor Sheludko wrote:
> I wonder, why don't we do RemoveHolderFromFlags() here?

It's ok, the flags value is not actually used.

https://codereview.chromium.org/2123983004/diff/80001/src/type-info.cc#oldcod...
src/type-info.cc:309: Code::Flags flags =
Code::ComputeHandlerFlags(Code::STORE_IC);
On 2016/07/07 23:02:26, Igor Sheludko wrote:
> ... and here?

Same here.

[Jakob Kummerow, 2016-07-13 09:54:46]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2016-07-13 09:54:48]

LGTM

https://codereview.chromium.org/2123983004/diff/90001/src/ic/x64/stub-cache-x...
File src/ic/x64/stub-cache-x64.cc (right):

https://codereview.chromium.org/2123983004/diff/90001/src/ic/x64/stub-cache-x...
src/ic/x64/stub-cache-x64.cc:108: if (IC::ICUseVector(ic_kind_)) {
This can be a DCHECK now (or dropped entirely); all load and store ICs always
use the vector.
...come to think of it, there are so many uses of ICUseVector() that a separate
cleanup CL probably makes more sense, so feel free to keep this as it is for
now.

[ulan, 2016-07-13 10:00:01]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-07-13 10:00:02]

heap lgtm

[Igor Sheludko, 2016-07-13 10:00:31]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-07-13 10:00:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 10:25:00]

Description was changed from

==========
[ic] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701
==========

to

==========
[ic] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701
==========

[commit-bot: I haz the power, 2016-07-13 10:25:02]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2016-07-13 10:27:42]

Description was changed from

==========
[ic] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701
==========

to

==========
[ic] Split megamorphic stub cache in two caches (for loads and for stores).

After this CL we can avoid using Code::flags in hash computations for
megamorphic
stub caches and therefore the unused ICState field can be finally removed from
flags.

BUG=chromium:618701

Committed: https://crrev.com/b449dc0b6fc33e92563f1a31cd523f02aa31baae
Cr-Commit-Position: refs/heads/master@{#37708}
==========

[commit-bot: I haz the power, 2016-07-13 10:27:44]

Patchset 2 (id:??) landed as
https://crrev.com/b449dc0b6fc33e92563f1a31cd523f02aa31baae
Cr-Commit-Position: refs/heads/master@{#37708}