Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index 257560e46c34e7c039cc8e4d9e41d45652d32528..458bebd50323ee0a8dcb608f25890db24bf2e2c5 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -3485,10 +3485,8 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
__ j(not_equal, &miss);
__ push(slot);
__ push(vector);
- Code::Flags code_flags =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));
- masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,
- receiver, name, vector, scratch);
+ masm->isolate()->load_stub_cache()->GenerateProbe(masm, receiver, name,
+ vector, scratch);
__ pop(vector);
__ pop(slot);
@@ -3746,10 +3744,8 @@ void VectorStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
__ pop(value);
__ push(slot);
__ push(vector);
- Code::Flags code_flags =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));
- masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,
- receiver, key, slot, no_reg);
+ masm->isolate()->store_stub_cache()->GenerateProbe(masm, receiver, key, slot,
+ no_reg);
__ pop(vector);
__ pop(slot);
Label no_pop_miss;
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/ic/arm/ic-arm.cc » ('j') | src/ic/x64/stub-cache-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698