Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: src/ic/stub-cache.h

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic/stub-cache.h
diff --git a/src/ic/stub-cache.h b/src/ic/stub-cache.h
index 03afcdcda5706726cdba2201a209383a47f0c989..b636aacc76566bfc1a36ec22119047368c5e6279 100644
--- a/src/ic/stub-cache.h
+++ b/src/ic/stub-cache.h
@@ -52,8 +52,7 @@ class StubCache {
// Arguments extra, extra2 and extra3 may be used to pass additional scratch
// registers. Set to no_reg if not needed.
// If leave_frame is true, then exit a frame before the tail call.
- void GenerateProbe(MacroAssembler* masm, Code::Kind ic_kind,
- Code::Flags flags, Register receiver, Register name,
+ void GenerateProbe(MacroAssembler* masm, Register receiver, Register name,
Register scratch, Register extra, Register extra2 = no_reg,
Register extra3 = no_reg);
@@ -86,6 +85,7 @@ class StubCache {
}
Isolate* isolate() { return isolate_; }
+ Code::Kind ic_kind() const { return ic_kind_; }
// Setting the entry size such that the index is shifted by Name::kHashShift
// is convenient; shifting down the length field (to extract the hash code)
@@ -107,7 +107,7 @@ class StubCache {
}
// The constructor is made public only for the purposes of testing.
- explicit StubCache(Isolate* isolate);
+ StubCache(Isolate* isolate, Code::Kind ic_kind);
private:
// The stub cache has a primary and secondary level. The two levels have
@@ -169,6 +169,7 @@ class StubCache {
Entry primary_[kPrimaryTableSize];
Entry secondary_[kSecondaryTableSize];
Isolate* isolate_;
+ Code::Kind ic_kind_;
friend class Isolate;
friend class SCTableReference;

Powered by Google App Engine
This is Rietveld 408576698