Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: test/cctest/test-code-stub-assembler.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ic/x64/stub-cache-x64.cc ('K') | « src/x87/code-stubs-x87.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-code-stub-assembler.cc
diff --git a/test/cctest/test-code-stub-assembler.cc b/test/cctest/test-code-stub-assembler.cc
index 2d9b666b6d5f16a3defef091e8ab08d1eb38a7af..7709f84678b1c09f2a880267f7bd6ba322a67435 100644
--- a/test/cctest/test-code-stub-assembler.cc
+++ b/test/cctest/test-code-stub-assembler.cc
@@ -1216,10 +1216,11 @@ TEST(TryProbeStubCache) {
const int kNumParams = 3;
CodeStubAssemblerTester m(isolate, kNumParams);
+ Code::Kind ic_kind = Code::LOAD_IC;
Code::Flags flags_to_query =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));
+ Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(ic_kind));
- StubCache stub_cache(isolate);
+ StubCache stub_cache(isolate, ic_kind);
stub_cache.Clear();
{
@@ -1232,8 +1233,8 @@ TEST(TryProbeStubCache) {
Variable var_handler(&m, MachineRepresentation::kTagged);
Label if_handler(&m), if_miss(&m);
- m.TryProbeStubCache(&stub_cache, flags_to_query, receiver, name,
- &if_handler, &var_handler, &if_miss);
+ m.TryProbeStubCache(&stub_cache, receiver, name, &if_handler, &var_handler,
+ &if_miss);
m.Bind(&if_handler);
m.BranchIfWordEqual(expected_handler, var_handler.value(), &passed,
&failed);
« src/ic/x64/stub-cache-x64.cc ('K') | « src/x87/code-stubs-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698