Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/x87/code-stubs-x87.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 3279 matching lines...) Expand 10 before | Expand all | Expand 10 after
3290 __ bind(&try_array); 3290 __ bind(&try_array);
3291 __ CompareRoot(FieldOperand(scratch, 0), Heap::kFixedArrayMapRootIndex); 3291 __ CompareRoot(FieldOperand(scratch, 0), Heap::kFixedArrayMapRootIndex);
3292 __ j(not_equal, &not_array); 3292 __ j(not_equal, &not_array);
3293 HandleArrayCases(masm, receiver, name, vector, slot, scratch, true, &miss); 3293 HandleArrayCases(masm, receiver, name, vector, slot, scratch, true, &miss);
3294 3294
3295 __ bind(&not_array); 3295 __ bind(&not_array);
3296 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex); 3296 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex);
3297 __ j(not_equal, &miss); 3297 __ j(not_equal, &miss);
3298 __ push(slot); 3298 __ push(slot);
3299 __ push(vector); 3299 __ push(vector);
3300 Code::Flags code_flags = 3300 masm->isolate()->load_stub_cache()->GenerateProbe(masm, receiver, name,
3301 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC)); 3301 vector, scratch);
3302 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,
3303 receiver, name, vector, scratch);
3304 __ pop(vector); 3302 __ pop(vector);
3305 __ pop(slot); 3303 __ pop(slot);
3306 3304
3307 __ bind(&miss); 3305 __ bind(&miss);
3308 LoadIC::GenerateMiss(masm); 3306 LoadIC::GenerateMiss(masm);
3309 } 3307 }
3310 3308
3311 3309
3312 void KeyedLoadICStub::Generate(MacroAssembler* masm) { 3310 void KeyedLoadICStub::Generate(MacroAssembler* masm) {
3313 GenerateImpl(masm, false); 3311 GenerateImpl(masm, false);
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
3551 HandlePolymorphicStoreCase(masm, receiver, key, vector, slot, scratch, true, 3549 HandlePolymorphicStoreCase(masm, receiver, key, vector, slot, scratch, true,
3552 &miss); 3550 &miss);
3553 3551
3554 __ bind(&not_array); 3552 __ bind(&not_array);
3555 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex); 3553 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex);
3556 __ j(not_equal, &miss); 3554 __ j(not_equal, &miss);
3557 3555
3558 __ pop(value); 3556 __ pop(value);
3559 __ push(slot); 3557 __ push(slot);
3560 __ push(vector); 3558 __ push(vector);
3561 Code::Flags code_flags = 3559 masm->isolate()->store_stub_cache()->GenerateProbe(masm, receiver, key, slot,
3562 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC)); 3560 no_reg);
3563 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,
3564 receiver, key, slot, no_reg);
3565 __ pop(vector); 3561 __ pop(vector);
3566 __ pop(slot); 3562 __ pop(slot);
3567 Label no_pop_miss; 3563 Label no_pop_miss;
3568 __ jmp(&no_pop_miss); 3564 __ jmp(&no_pop_miss);
3569 3565
3570 __ bind(&miss); 3566 __ bind(&miss);
3571 __ pop(value); 3567 __ pop(value);
3572 __ bind(&no_pop_miss); 3568 __ bind(&no_pop_miss);
3573 StoreIC::GenerateMiss(masm); 3569 StoreIC::GenerateMiss(masm);
3574 } 3570 }
(...skipping 1716 matching lines...) Expand 10 before | Expand all | Expand 10 after
5291 kStackUnwindSpace, nullptr, return_value_operand, 5287 kStackUnwindSpace, nullptr, return_value_operand,
5292 NULL); 5288 NULL);
5293 } 5289 }
5294 5290
5295 #undef __ 5291 #undef __
5296 5292
5297 } // namespace internal 5293 } // namespace internal
5298 } // namespace v8 5294 } // namespace v8
5299 5295
5300 #endif // V8_TARGET_ARCH_X87 5296 #endif // V8_TARGET_ARCH_X87
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698