Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/arm/code-stubs-arm.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/ic/x64/stub-cache-x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/code-stubs-arm.cc
diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc
index 238cc6b1247a72920fd734d6b784899b70f9aef3..47f5a3e0735899216b622e3933e0bf220d1eafc5 100644
--- a/src/arm/code-stubs-arm.cc
+++ b/src/arm/code-stubs-arm.cc
@@ -3525,11 +3525,8 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
__ bind(&not_array);
__ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
__ b(ne, &miss);
- Code::Flags code_flags =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));
- masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,
- receiver, name, feedback,
- receiver_map, scratch1, r9);
+ masm->isolate()->load_stub_cache()->GenerateProbe(
+ masm, receiver, name, feedback, receiver_map, scratch1, r9);
__ bind(&miss);
LoadIC::GenerateMiss(masm);
@@ -3670,11 +3667,8 @@ void VectorStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
__ bind(&not_array);
__ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
__ b(ne, &miss);
- Code::Flags code_flags =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));
- masm->isolate()->stub_cache()->GenerateProbe(
- masm, Code::STORE_IC, code_flags, receiver, key, feedback, receiver_map,
- scratch1, scratch2);
+ masm->isolate()->store_stub_cache()->GenerateProbe(
+ masm, receiver, key, feedback, receiver_map, scratch1, scratch2);
__ bind(&miss);
StoreIC::GenerateMiss(masm);
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/ic/x64/stub-cache-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698