Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: src/x87/code-stubs-x87.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x87/code-stubs-x87.cc
diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc
index e0cc2c0f50a9d5ed4ff9c19fe1e76f336bef7822..9ff6a007aa6fe19b4555f645ebd81cc22af2544c 100644
--- a/src/x87/code-stubs-x87.cc
+++ b/src/x87/code-stubs-x87.cc
@@ -3297,10 +3297,8 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
__ j(not_equal, &miss);
__ push(slot);
__ push(vector);
- Code::Flags code_flags =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));
- masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,
- receiver, name, vector, scratch);
+ masm->isolate()->load_stub_cache()->GenerateProbe(masm, receiver, name,
+ vector, scratch);
__ pop(vector);
__ pop(slot);
@@ -3558,10 +3556,8 @@ void VectorStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
__ pop(value);
__ push(slot);
__ push(vector);
- Code::Flags code_flags =
- Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));
- masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,
- receiver, key, slot, no_reg);
+ masm->isolate()->store_stub_cache()->GenerateProbe(masm, receiver, key, slot,
+ no_reg);
__ pop(vector);
__ pop(slot);
Label no_pop_miss;

Powered by Google App Engine
This is Rietveld 408576698