Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 3467 matching lines...) Expand 10 before | Expand all | Expand 10 after
3478 __ bind(&try_array); 3478 __ bind(&try_array);
3479 __ CompareRoot(FieldOperand(scratch, 0), Heap::kFixedArrayMapRootIndex); 3479 __ CompareRoot(FieldOperand(scratch, 0), Heap::kFixedArrayMapRootIndex);
3480 __ j(not_equal, &not_array); 3480 __ j(not_equal, &not_array);
3481 HandleArrayCases(masm, receiver, name, vector, slot, scratch, true, &miss); 3481 HandleArrayCases(masm, receiver, name, vector, slot, scratch, true, &miss);
3482 3482
3483 __ bind(&not_array); 3483 __ bind(&not_array);
3484 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex); 3484 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex);
3485 __ j(not_equal, &miss); 3485 __ j(not_equal, &miss);
3486 __ push(slot); 3486 __ push(slot);
3487 __ push(vector); 3487 __ push(vector);
3488 Code::Flags code_flags = 3488 masm->isolate()->load_stub_cache()->GenerateProbe(masm, receiver, name,
3489 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC)); 3489 vector, scratch);
3490 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,
3491 receiver, name, vector, scratch);
3492 __ pop(vector); 3490 __ pop(vector);
3493 __ pop(slot); 3491 __ pop(slot);
3494 3492
3495 __ bind(&miss); 3493 __ bind(&miss);
3496 LoadIC::GenerateMiss(masm); 3494 LoadIC::GenerateMiss(masm);
3497 } 3495 }
3498 3496
3499 3497
3500 void KeyedLoadICStub::Generate(MacroAssembler* masm) { 3498 void KeyedLoadICStub::Generate(MacroAssembler* masm) {
3501 GenerateImpl(masm, false); 3499 GenerateImpl(masm, false);
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
3739 HandlePolymorphicStoreCase(masm, receiver, key, vector, slot, scratch, true, 3737 HandlePolymorphicStoreCase(masm, receiver, key, vector, slot, scratch, true,
3740 &miss); 3738 &miss);
3741 3739
3742 __ bind(&not_array); 3740 __ bind(&not_array);
3743 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex); 3741 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex);
3744 __ j(not_equal, &miss); 3742 __ j(not_equal, &miss);
3745 3743
3746 __ pop(value); 3744 __ pop(value);
3747 __ push(slot); 3745 __ push(slot);
3748 __ push(vector); 3746 __ push(vector);
3749 Code::Flags code_flags = 3747 masm->isolate()->store_stub_cache()->GenerateProbe(masm, receiver, key, slot,
3750 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC)); 3748 no_reg);
3751 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,
3752 receiver, key, slot, no_reg);
3753 __ pop(vector); 3749 __ pop(vector);
3754 __ pop(slot); 3750 __ pop(slot);
3755 Label no_pop_miss; 3751 Label no_pop_miss;
3756 __ jmp(&no_pop_miss); 3752 __ jmp(&no_pop_miss);
3757 3753
3758 __ bind(&miss); 3754 __ bind(&miss);
3759 __ pop(value); 3755 __ pop(value);
3760 __ bind(&no_pop_miss); 3756 __ bind(&no_pop_miss);
3761 StoreIC::GenerateMiss(masm); 3757 StoreIC::GenerateMiss(masm);
3762 } 3758 }
(...skipping 1738 matching lines...) Expand 10 before | Expand all | Expand 10 after
5501 kStackUnwindSpace, nullptr, return_value_operand, 5497 kStackUnwindSpace, nullptr, return_value_operand,
5502 NULL); 5498 NULL);
5503 } 5499 }
5504 5500
5505 #undef __ 5501 #undef __
5506 5502
5507 } // namespace internal 5503 } // namespace internal
5508 } // namespace v8 5504 } // namespace v8
5509 5505
5510 #endif // V8_TARGET_ARCH_IA32 5506 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/ic/arm/ic-arm.cc » ('j') | src/ic/x64/stub-cache-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698