Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 21114002: Add initial prototype for the GN meta-buildsystem. (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, tfarina
Visibility:
Public.

Description

Add initial prototype for the GN meta-buildsystem. This is currently not hooked into the build. To build, add a reference to the gn.gyp file to build/all.gyp R=darin@chromium.org, scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214254

Patch Set 1 #

Total comments: 1

Patch Set 2 : add owners and readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18181 lines, -14 lines) Patch
A .gn View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/gn/BUILD.gn View 1 chunk +153 lines, -0 lines 0 comments Download
A + tools/gn/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A tools/gn/README.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A tools/gn/build_settings.h View 1 chunk +110 lines, -0 lines 0 comments Download
A tools/gn/build_settings.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A tools/gn/command_desc.cc View 1 chunk +201 lines, -0 lines 0 comments Download
A tools/gn/command_gen.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A tools/gn/commands.h View 1 chunk +18 lines, -0 lines 0 comments Download
A tools/gn/config.h View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/gn/config.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A tools/gn/config_values.h View 1 chunk +50 lines, -0 lines 0 comments Download
A + tools/gn/config_values.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
A tools/gn/config_values_extractors.h View 1 chunk +50 lines, -0 lines 0 comments Download
A tools/gn/config_values_extractors.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/gn/config_values_generator.h View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/gn/config_values_generator.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A tools/gn/err.h View 1 chunk +85 lines, -0 lines 0 comments Download
A tools/gn/err.cc View 1 chunk +196 lines, -0 lines 0 comments Download
A tools/gn/escape.h View 1 chunk +53 lines, -0 lines 0 comments Download
A tools/gn/escape.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A + tools/gn/escape_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A tools/gn/file_template.h View 1 chunk +74 lines, -0 lines 0 comments Download
A tools/gn/file_template.cc View 1 chunk +125 lines, -0 lines 0 comments Download
A tools/gn/file_template_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/gn/filesystem_utils.h View 1 chunk +115 lines, -0 lines 0 comments Download
A tools/gn/filesystem_utils.cc View 1 chunk +350 lines, -0 lines 0 comments Download
A tools/gn/filesystem_utils_unittest.cc View 1 chunk +146 lines, -0 lines 0 comments Download
A tools/gn/function_define_rule.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A tools/gn/function_exec_script.cc View 1 chunk +254 lines, -0 lines 0 comments Download
A tools/gn/function_process_file_template.cc View 1 chunk +65 lines, -0 lines 0 comments Download
A tools/gn/function_read_file.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A tools/gn/function_set_default_toolchain.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A tools/gn/function_template.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/gn/function_toolchain.cc View 1 chunk +126 lines, -0 lines 0 comments Download
A tools/gn/function_write_file.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A tools/gn/functions.h View 1 chunk +182 lines, -0 lines 0 comments Download
A tools/gn/functions.cc View 1 chunk +443 lines, -0 lines 0 comments Download
A tools/gn/functions_target.cc View 1 chunk +221 lines, -0 lines 0 comments Download
A tools/gn/generate_test_gn_data.cc View 1 chunk +129 lines, -0 lines 0 comments Download
A tools/gn/gn.gyp View 1 chunk +171 lines, -0 lines 0 comments Download
A tools/gn/gn_main.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A tools/gn/import_manager.h View 1 chunk +41 lines, -0 lines 0 comments Download
A tools/gn/import_manager.cc View 1 chunk +83 lines, -0 lines 0 comments Download
A tools/gn/input_conversion.h View 1 chunk +26 lines, -0 lines 0 comments Download
A tools/gn/input_conversion.cc View 1 chunk +205 lines, -0 lines 0 comments Download
A tools/gn/input_conversion_unittest.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A tools/gn/input_file.h View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/gn/input_file.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A tools/gn/input_file_manager.h View 1 chunk +123 lines, -0 lines 0 comments Download
A tools/gn/input_file_manager.cc View 1 chunk +254 lines, -0 lines 0 comments Download
A tools/gn/item.h View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/gn/item.cc View 1 chunk +31 lines, -0 lines 0 comments Download
A tools/gn/item_node.h View 1 chunk +119 lines, -0 lines 0 comments Download
A tools/gn/item_node.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A tools/gn/item_tree.h View 1 chunk +69 lines, -0 lines 0 comments Download
A tools/gn/item_tree.cc View 1 chunk +193 lines, -0 lines 0 comments Download
A tools/gn/label.h View 1 chunk +116 lines, -0 lines 0 comments Download
A tools/gn/label.cc View 1 chunk +263 lines, -0 lines 0 comments Download
A tools/gn/label_unittest.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A tools/gn/location.h View 1 chunk +77 lines, -0 lines 0 comments Download
A tools/gn/ninja_build_writer.h View 1 chunk +53 lines, -0 lines 0 comments Download
A tools/gn/ninja_build_writer.cc View 1 chunk +165 lines, -0 lines 0 comments Download
A tools/gn/ninja_helper.h View 1 chunk +71 lines, -0 lines 0 comments Download
A tools/gn/ninja_helper.cc View 1 chunk +165 lines, -0 lines 0 comments Download
A tools/gn/ninja_helper_unittest.cc View 1 chunk +73 lines, -0 lines 0 comments Download
A tools/gn/ninja_target_writer.h View 1 chunk +67 lines, -0 lines 0 comments Download
A tools/gn/ninja_target_writer.cc View 1 chunk +550 lines, -0 lines 0 comments Download
A tools/gn/ninja_toolchain_writer.h View 1 chunk +46 lines, -0 lines 0 comments Download
A tools/gn/ninja_toolchain_writer.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A tools/gn/ninja_writer.h View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/gn/ninja_writer.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A tools/gn/operators.h View 1 chunk +35 lines, -0 lines 0 comments Download
A tools/gn/operators.cc View 1 chunk +573 lines, -0 lines 0 comments Download
A tools/gn/output_file.h View 1 chunk +41 lines, -0 lines 0 comments Download
A tools/gn/output_stream.h View 1 chunk +42 lines, -0 lines 0 comments Download
A tools/gn/parse_tree.h View 1 chunk +366 lines, -0 lines 0 comments Download
A tools/gn/parse_tree.cc View 1 chunk +472 lines, -0 lines 0 comments Download
A tools/gn/parser.h View 1 chunk +81 lines, -0 lines 0 comments Download
A tools/gn/parser.cc View 1 chunk +470 lines, -0 lines 0 comments Download
A tools/gn/parser_unittest.cc View 1 chunk +329 lines, -0 lines 0 comments Download
A tools/gn/path_output.h View 1 chunk +80 lines, -0 lines 0 comments Download
A tools/gn/path_output.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A tools/gn/path_output_unittest.cc View 1 chunk +193 lines, -0 lines 0 comments Download
A tools/gn/pattern.h View 1 chunk +86 lines, -0 lines 0 comments Download
A tools/gn/pattern.cc View 1 chunk +185 lines, -0 lines 0 comments Download
A tools/gn/pattern_unittest.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A tools/gn/scheduler.h View 1 chunk +90 lines, -0 lines 0 comments Download
A tools/gn/scheduler.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A tools/gn/scope.h View 1 chunk +260 lines, -0 lines 0 comments Download
A tools/gn/scope.cc View 1 chunk +372 lines, -0 lines 0 comments Download
A tools/gn/scope_per_file_provider.h View 1 chunk +79 lines, -0 lines 0 comments Download
A tools/gn/scope_per_file_provider.cc View 1 chunk +186 lines, -0 lines 0 comments Download
A tools/gn/secondary/base/BUILD.gn View 1 chunk +919 lines, -0 lines 0 comments Download
A tools/gn/secondary/base/allocator/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/gn/secondary/base/third_party/dynamic_annotations/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/BUILD.gn View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/BUILDCONFIG.gn View 1 chunk +187 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/compiler/BUILD.gn View 1 chunk +134 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/win/BUILD.gn View 1 chunk +184 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/win/get_msvc_config.py View 1 chunk +77 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/win/get_msvc_config_real.py View 1 chunk +575 lines, -0 lines 0 comments Download
A tools/gn/secondary/ipc/BUILD.gn View 1 chunk +168 lines, -0 lines 0 comments Download
A tools/gn/secondary/testing/BUILD.gn View 1 chunk +44 lines, -0 lines 0 comments Download
A + tools/gn/secondary/third_party/modp_b64/BUILD.gn View 1 1 chunk +11 lines, -5 lines 0 comments Download
A tools/gn/settings.h View 1 chunk +107 lines, -0 lines 0 comments Download
A tools/gn/settings.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/gn/setup.h View 1 chunk +69 lines, -0 lines 0 comments Download
A tools/gn/setup.cc View 1 chunk +195 lines, -0 lines 0 comments Download
A tools/gn/source_dir.h View 1 chunk +104 lines, -0 lines 0 comments Download
A tools/gn/source_dir.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A tools/gn/source_dir_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/gn/source_file.h View 1 chunk +97 lines, -0 lines 0 comments Download
A tools/gn/source_file.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A tools/gn/standard_out.h View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/gn/standard_out.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A tools/gn/string_utils.h View 1 chunk +51 lines, -0 lines 0 comments Download
A tools/gn/string_utils.cc View 1 chunk +168 lines, -0 lines 0 comments Download
A tools/gn/string_utils_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A tools/gn/target.h View 1 chunk +145 lines, -0 lines 0 comments Download
A tools/gn/target.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A tools/gn/target_generator.h View 1 chunk +83 lines, -0 lines 0 comments Download
A tools/gn/target_generator.cc View 1 chunk +334 lines, -0 lines 0 comments Download
A + tools/gn/target_generator_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A tools/gn/target_manager.h View 1 chunk +73 lines, -0 lines 0 comments Download
A tools/gn/target_manager.cc View 1 chunk +134 lines, -0 lines 0 comments Download
A tools/gn/target_manager_unittest.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A tools/gn/token.h View 1 chunk +52 lines, -0 lines 0 comments Download
A tools/gn/token.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A tools/gn/tokenizer.h View 1 chunk +86 lines, -0 lines 0 comments Download
A tools/gn/tokenizer.cc View 1 chunk +309 lines, -0 lines 0 comments Download
A tools/gn/tokenizer_unittest.cc View 1 chunk +162 lines, -0 lines 0 comments Download
A tools/gn/toolchain.h View 1 chunk +94 lines, -0 lines 0 comments Download
A tools/gn/toolchain.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A tools/gn/toolchain_manager.h View 1 chunk +167 lines, -0 lines 0 comments Download
A tools/gn/toolchain_manager.cc View 1 chunk +480 lines, -0 lines 0 comments Download
A tools/gn/value.h View 1 chunk +91 lines, -0 lines 0 comments Download
A tools/gn/value.cc View 1 chunk +126 lines, -0 lines 0 comments Download
A tools/gn/value_extractors.h View 1 chunk +57 lines, -0 lines 0 comments Download
A tools/gn/value_extractors.cc View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
brettw
darin, please review toplevel .gn file addition. scottmg: please review the 12,952 lines of C++ ...
5 years, 10 months ago (2013-07-29 18:00:23 UTC) #1
scottmg
On 2013/07/29 18:00:23, brettw wrote: > darin, please review toplevel .gn file addition. > > ...
5 years, 10 months ago (2013-07-29 18:13:39 UTC) #2
scottmg
On 2013/07/29 18:13:39, scottmg wrote: > On 2013/07/29 18:00:23, brettw wrote: > > darin, please ...
5 years, 10 months ago (2013-07-29 19:14:49 UTC) #3
darin (slow to review)
rubber stamp LGTM
5 years, 10 months ago (2013-07-29 21:39:49 UTC) #4
tfarina
Can you add a README with a simple overview of what GN is? It seems ...
5 years, 10 months ago (2013-07-29 21:45:06 UTC) #5
tfarina
Looks like we will transition from gyp to .gn? Is there a bug that you ...
5 years, 10 months ago (2013-07-29 21:51:23 UTC) #6
darin (slow to review)
On 2013/07/29 21:51:23, tfarina wrote: > Looks like we will transition from gyp to .gn? ...
5 years, 10 months ago (2013-07-29 21:55:34 UTC) #7
tfarina
On 2013/07/29 21:55:34, darin wrote: > On 2013/07/29 21:51:23, tfarina wrote: > > Looks like ...
5 years, 10 months ago (2013-07-29 22:33:48 UTC) #8
brettw
5 years, 10 months ago (2013-07-29 23:30:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r214254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698