Refactor net tests to use GMock matchers for checking net::Error results

Refactor net tests to use GMock matchers for checking net::Error results

Uses matchers introduced in
https://chromiumcodereview-hr.appspot.com/2111093002/.

ASSERT_EQ(net::ERR_*, ...) -> ASSERT_THAT(..., IsError(net::ERR_*))
ASSERT_EQ(net::OK, ...) -> ASSERT_THAT(..., IsOk())
EXPECT_EQ(net::ERR_*, ...) -> EXPECT_THAT(..., IsError(net::ERR_*))
EXPECT_EQ(net::OK, ...) -> EXPECT_THAT(..., IsOk())

Also done for cases where the "net::" prefix is omitted.

Committed: https://crrev.com/214763f5198b2a99f6f4e2104b67aa5359837b86
Cr-Commit-Position: refs/heads/master@{#403561}

[Rob Percival, 2016-07-01 09:13:52]

robpercival@chromium.org changed reviewers:
+ eroman@chromium.org

[Rob Percival, 2016-07-01 09:13:53]

PTAL

[Rob Percival, 2016-07-01 09:14:15]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 09:14:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 10:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 10:49:53]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-07-01 19:00:55]

rubberstamp LGTM
(I verified a subset of the files but not all).

[Rob Percival, 2016-07-01 23:15:24]

On 2016/07/01 19:00:55, eroman wrote:
> rubberstamp LGTM
> (I verified a subset of the files but not all).

Does that mean you're happy for me to commit it?

[eroman, 2016-07-01 23:16:04]

Correct

On Fri, Jul 1, 2016 at 4:15 PM, <robpercival@chromium.org> wrote:

> On 2016/07/01 19:00:55, eroman wrote:
> > rubberstamp LGTM
> > (I verified a subset of the files but not all).
>
> Does that mean you're happy for me to commit it?
>
> https://codereview.chromium.org/2109503009/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Rob Percival, 2016-07-01 23:18:22]

The CQ bit was checked by robpercival@chromium.org

[commit-bot: I haz the power, 2016-07-01 23:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 23:27:22]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-07-01 23:29:23]

Description was changed from

==========
Refactor net tests to use GMock matchers for checking net::Error results

Uses matchers introduced in
https://chromiumcodereview-hr.appspot.com/2111093002/.

ASSERT_EQ(net::ERR_*, ...) -> ASSERT_THAT(..., IsError(net::ERR_*))
ASSERT_EQ(net::OK, ...) -> ASSERT_THAT(..., IsOk())
EXPECT_EQ(net::ERR_*, ...) -> EXPECT_THAT(..., IsError(net::ERR_*))
EXPECT_EQ(net::OK, ...) -> EXPECT_THAT(..., IsOk())

Also done for cases where the "net::" prefix is omitted.
==========

to

==========
Refactor net tests to use GMock matchers for checking net::Error results

Uses matchers introduced in
https://chromiumcodereview-hr.appspot.com/2111093002/.

ASSERT_EQ(net::ERR_*, ...) -> ASSERT_THAT(..., IsError(net::ERR_*))
ASSERT_EQ(net::OK, ...) -> ASSERT_THAT(..., IsOk())
EXPECT_EQ(net::ERR_*, ...) -> EXPECT_THAT(..., IsError(net::ERR_*))
EXPECT_EQ(net::OK, ...) -> EXPECT_THAT(..., IsOk())

Also done for cases where the "net::" prefix is omitted.

Committed: https://crrev.com/214763f5198b2a99f6f4e2104b67aa5359837b86
Cr-Commit-Position: refs/heads/master@{#403561}
==========

[commit-bot: I haz the power, 2016-07-01 23:29:24]

Patchset 2 (id:??) landed as
https://crrev.com/214763f5198b2a99f6f4e2104b67aa5359837b86
Cr-Commit-Position: refs/heads/master@{#403561}