Refactor net tests to use GMock matchers for checking net::Error results

net/cert/caching_cert_verifier_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/caching_cert_verifier.h"
 
 #include <memory>
 
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_completion_callback.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/cert_verify_result.h"
 #include "net/cert/mock_cert_verifier.h"
 #include "net/cert/x509_certificate.h"
 #include "net/log/net_log.h"
 #include "net/test/cert_test_util.h"
+#include "net/test/gtest_util.h"
 #include "net/test/test_data_directory.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using net::test::IsError;
+using net::test::IsOk;
+
 using testing::_;
 using testing::Mock;
 using testing::Return;
 using testing::ReturnRef;
 
 namespace net {
 
 namespace {
 
 class MockCacheVisitor : public CachingCertVerifier::CacheVisitor {
@@ skipping 147 matching lines @@
   ASSERT_EQ(0u, verifier_.cache_hits());
   ASSERT_EQ(1u, verifier_.GetCacheSize());
 
   TestCompletionCallback callback;
   std::unique_ptr<CertVerifier::Request> request;
 
   CertVerifyResult cached_result;
   int error = callback.GetResult(
       verifier_.Verify(params, nullptr, &cached_result, callback.callback(),
                        &request, BoundNetLog()));
-  ASSERT_EQ(ERR_CERT_WEAK_KEY, error);
+  ASSERT_THAT(error, IsError(ERR_CERT_WEAK_KEY));
   EXPECT_TRUE(cached_result.has_md2);
   EXPECT_FALSE(cached_result.is_issued_by_known_root);
 
   ASSERT_EQ(1u, verifier_.requests());
   ASSERT_EQ(1u, verifier_.cache_hits());
   ASSERT_EQ(1u, verifier_.GetCacheSize());
 
   // But it should not be fine to replace it with an existing entry, even
   // if that entry is 'newer'.
   EXPECT_FALSE(verifier_.AddEntry(params, OK, result_2,
                                   now + base::TimeDelta::FromMinutes(1)));
 
   error = callback.GetResult(verifier_.Verify(params, nullptr, &cached_result,
                                               callback.callback(), &request,
                                               BoundNetLog()));
-  ASSERT_EQ(ERR_CERT_WEAK_KEY, error);
+  ASSERT_THAT(error, IsError(ERR_CERT_WEAK_KEY));
   EXPECT_TRUE(cached_result.has_md2);
   EXPECT_FALSE(cached_result.is_issued_by_known_root);
 
   ASSERT_EQ(2u, verifier_.requests());
   ASSERT_EQ(2u, verifier_.cache_hits());
   ASSERT_EQ(1u, verifier_.GetCacheSize());
 }
 
 // Tests the same server certificate with different intermediate CA
 // certificates.  These should be treated as different certificate chains even
@@ skipping 45 matching lines @@
       CertVerifier::RequestParams(cert_chain2, "www.example.com", 0,
                                   std::string(), CertificateList()),
       nullptr, &verify_result, callback.callback(), &request, BoundNetLog()));
   ASSERT_TRUE(IsCertificateError(error));
   ASSERT_EQ(2u, verifier_.requests());
   ASSERT_EQ(0u, verifier_.cache_hits());
   ASSERT_EQ(2u, verifier_.GetCacheSize());
 }
 
 }  // namespace net