Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2202)

Unified Diff: net/quic/p2p/quic_p2p_session_test.cc

Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to contents.txt files Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/p2p/quic_p2p_session_test.cc
diff --git a/net/quic/p2p/quic_p2p_session_test.cc b/net/quic/p2p/quic_p2p_session_test.cc
index 04f8ef46768f3a8ea475a3842436d91b3c018fec..eebc68b00798f01f81bebe21c3dd053499186392 100644
--- a/net/quic/p2p/quic_p2p_session_test.cc
+++ b/net/quic/p2p/quic_p2p_session_test.cc
@@ -26,8 +26,12 @@
#include "net/quic/quic_chromium_packet_writer.h"
#include "net/quic/test_tools/quic_session_peer.h"
#include "net/socket/socket.h"
+#include "net/test/gtest_util.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+using net::test::IsOk;
+
namespace net {
namespace {
@@ -263,7 +267,7 @@ class QuicP2PSessionTest : public ::testing::Test {
};
void QuicP2PSessionTest::OnWriteResult(int result) {
- EXPECT_EQ(OK, result);
+ EXPECT_THAT(result, IsOk());
}
void QuicP2PSessionTest::TestStreamConnection(QuicP2PSession* from_session,
« no previous file with comments | « net/quic/crypto/properties_based_quic_server_info_test.cc ('k') | net/quic/quic_chromium_client_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698