net/spdy/spdy_test_util_common.cc - Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_test_util_common.cc

Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert changes to contents.txt files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_test_util_common.cc

diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc

index 5ff57e89ac8e578578d0c3c3989daaa3005b4edc..5cb0edc70a91a5e9a5b47fe63e147d0f9d36c4fb 100644

--- a/net/spdy/spdy_test_util_common.cc

+++ b/net/spdy/spdy_test_util_common.cc

@@ -32,7 +32,11 @@

#include "net/spdy/spdy_session.h"

#include "net/spdy/spdy_session_pool.h"

#include "net/spdy/spdy_stream.h"

+#include "net/test/gtest_util.h"

#include "net/url_request/url_request_job_factory_impl.h"

+#include "testing/gmock/include/gmock/gmock.h"

+using net::test::IsOk;

namespace net {

@@ -523,7 +527,7 @@ base::WeakPtr<SpdySession> CreateSpdySessionHelper(

if (rv == ERR_IO_PENDING)

rv = callback.WaitForResult();

- EXPECT_EQ(OK, rv);

+ EXPECT_THAT(rv, IsOk());

base::WeakPtr<SpdySession> spdy_session =

http_session->spdy_session_pool()->CreateAvailableSessionFromSocket(

« no previous file with comments | « net/spdy/spdy_stream_unittest.cc ('k') | net/ssl/channel_id_service_unittest.cc » ('j') | no next file with comments »