Index: net/socket/tcp_server_socket_unittest.cc |
diff --git a/net/socket/tcp_server_socket_unittest.cc b/net/socket/tcp_server_socket_unittest.cc |
index a0d6c49c98cd330eee7ce0bf30010ef5b6998442..c6a29e3503002ba72a3ae74e394de1efacc4485e 100644 |
--- a/net/socket/tcp_server_socket_unittest.cc |
+++ b/net/socket/tcp_server_socket_unittest.cc |
@@ -17,9 +17,13 @@ |
#include "net/base/net_errors.h" |
#include "net/base/test_completion_callback.h" |
#include "net/socket/tcp_client_socket.h" |
+#include "net/test/gtest_util.h" |
+#include "testing/gmock/include/gmock/gmock.h" |
#include "testing/gtest/include/gtest/gtest.h" |
#include "testing/platform_test.h" |
+using net::test::IsOk; |
+ |
namespace net { |
namespace { |
@@ -33,8 +37,8 @@ class TCPServerSocketTest : public PlatformTest { |
void SetUpIPv4() { |
IPEndPoint address(IPAddress::IPv4Localhost(), 0); |
- ASSERT_EQ(OK, socket_.Listen(address, kListenBacklog)); |
- ASSERT_EQ(OK, socket_.GetLocalAddress(&local_address_)); |
+ ASSERT_THAT(socket_.Listen(address, kListenBacklog), IsOk()); |
+ ASSERT_THAT(socket_.GetLocalAddress(&local_address_), IsOk()); |
} |
void SetUpIPv6(bool* success) { |
@@ -45,13 +49,13 @@ class TCPServerSocketTest : public PlatformTest { |
"disabled. Skipping the test"; |
return; |
} |
- ASSERT_EQ(OK, socket_.GetLocalAddress(&local_address_)); |
+ ASSERT_THAT(socket_.GetLocalAddress(&local_address_), IsOk()); |
*success = true; |
} |
static IPEndPoint GetPeerAddress(StreamSocket* socket) { |
IPEndPoint address; |
- EXPECT_EQ(OK, socket->GetPeerAddress(&address)); |
+ EXPECT_THAT(socket->GetPeerAddress(&address), IsOk()); |
return address; |
} |
@@ -76,7 +80,7 @@ TEST_F(TCPServerSocketTest, Accept) { |
int result = socket_.Accept(&accepted_socket, accept_callback.callback()); |
if (result == ERR_IO_PENDING) |
result = accept_callback.WaitForResult(); |
- ASSERT_EQ(OK, result); |
+ ASSERT_THAT(result, IsOk()); |
ASSERT_TRUE(accepted_socket.get() != NULL); |
@@ -84,7 +88,7 @@ TEST_F(TCPServerSocketTest, Accept) { |
EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), |
local_address_.address()); |
- EXPECT_EQ(OK, connect_callback.WaitForResult()); |
+ EXPECT_THAT(connect_callback.WaitForResult(), IsOk()); |
} |
// Test Accept() callback. |
@@ -102,8 +106,8 @@ TEST_F(TCPServerSocketTest, AcceptAsync) { |
NetLog::Source()); |
connecting_socket.Connect(connect_callback.callback()); |
- EXPECT_EQ(OK, connect_callback.WaitForResult()); |
- EXPECT_EQ(OK, accept_callback.WaitForResult()); |
+ EXPECT_THAT(connect_callback.WaitForResult(), IsOk()); |
+ EXPECT_THAT(accept_callback.WaitForResult(), IsOk()); |
EXPECT_TRUE(accepted_socket != NULL); |
@@ -132,16 +136,16 @@ TEST_F(TCPServerSocketTest, Accept2Connections) { |
NetLog::Source()); |
connecting_socket2.Connect(connect_callback2.callback()); |
- EXPECT_EQ(OK, accept_callback.WaitForResult()); |
+ EXPECT_THAT(accept_callback.WaitForResult(), IsOk()); |
TestCompletionCallback accept_callback2; |
std::unique_ptr<StreamSocket> accepted_socket2; |
int result = socket_.Accept(&accepted_socket2, accept_callback2.callback()); |
if (result == ERR_IO_PENDING) |
result = accept_callback2.WaitForResult(); |
- ASSERT_EQ(OK, result); |
+ ASSERT_THAT(result, IsOk()); |
- EXPECT_EQ(OK, connect_callback.WaitForResult()); |
+ EXPECT_THAT(connect_callback.WaitForResult(), IsOk()); |
EXPECT_TRUE(accepted_socket != NULL); |
EXPECT_TRUE(accepted_socket2 != NULL); |
@@ -169,7 +173,7 @@ TEST_F(TCPServerSocketTest, AcceptIPv6) { |
int result = socket_.Accept(&accepted_socket, accept_callback.callback()); |
if (result == ERR_IO_PENDING) |
result = accept_callback.WaitForResult(); |
- ASSERT_EQ(OK, result); |
+ ASSERT_THAT(result, IsOk()); |
ASSERT_TRUE(accepted_socket.get() != NULL); |
@@ -177,7 +181,7 @@ TEST_F(TCPServerSocketTest, AcceptIPv6) { |
EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), |
local_address_.address()); |
- EXPECT_EQ(OK, connect_callback.WaitForResult()); |
+ EXPECT_THAT(connect_callback.WaitForResult(), IsOk()); |
} |
TEST_F(TCPServerSocketTest, AcceptIO) { |
@@ -191,7 +195,7 @@ TEST_F(TCPServerSocketTest, AcceptIO) { |
TestCompletionCallback accept_callback; |
std::unique_ptr<StreamSocket> accepted_socket; |
int result = socket_.Accept(&accepted_socket, accept_callback.callback()); |
- ASSERT_EQ(OK, accept_callback.GetResult(result)); |
+ ASSERT_THAT(accept_callback.GetResult(result), IsOk()); |
ASSERT_TRUE(accepted_socket.get() != NULL); |
@@ -199,7 +203,7 @@ TEST_F(TCPServerSocketTest, AcceptIO) { |
EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), |
local_address_.address()); |
- EXPECT_EQ(OK, connect_callback.WaitForResult()); |
+ EXPECT_THAT(connect_callback.WaitForResult(), IsOk()); |
const std::string message("test message"); |
std::vector<char> buffer(message.size()); |