Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2614)

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to contents.txt files Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_http_job_unittest.cc ('k') | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job_factory_impl_unittest.cc
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index a829b1ae80f8a1740b001bc7201d9b9398a42d11..d0dd374ded77f8bb6386e6b7cfe5e5ce104ddcbe 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -14,11 +14,16 @@
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
#include "net/base/request_priority.h"
+#include "net/test/gtest_util.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_job.h"
#include "net/url_request/url_request_test_util.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+using net::test::IsError;
+using net::test::IsOk;
+
namespace net {
namespace {
@@ -65,7 +70,7 @@ TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
base::RunLoop().Run();
EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());
- EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request->status().error());
+ EXPECT_THAT(request->status().error(), IsError(ERR_UNKNOWN_URL_SCHEME));
}
TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
@@ -81,7 +86,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
base::RunLoop().Run();
EXPECT_EQ(URLRequestStatus::SUCCESS, request->status().status());
- EXPECT_EQ(OK, request->status().error());
+ EXPECT_THAT(request->status().error(), IsOk());
}
TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
« no previous file with comments | « net/url_request/url_request_http_job_unittest.cc ('k') | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698