Refactor net tests to use GMock matchers for checking net::Error results

net/http/http_network_transaction_ssl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "net/base/request_priority.h"
 #include "net/cert/ct_policy_enforcer.h"
 #include "net/cert/mock_cert_verifier.h"
 #include "net/cert/multi_log_ct_verifier.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/http/http_auth_handler_mock.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_network_transaction.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_server_properties_impl.h"
 #include "net/http/transport_security_state.h"
 #include "net/proxy/proxy_service.h"
 #include "net/socket/socket_test_util.h"
 #include "net/ssl/default_channel_id_store.h"
+#include "net/test/gtest_util.h"
+#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using net::test::IsOk;
+
 namespace net {
 
 namespace {
 
 class TLS10SSLConfigService : public SSLConfigService {
  public:
   TLS10SSLConfigService() {
     ssl_config_.version_min = SSL_PROTOCOL_VERSION_TLS1;
     ssl_config_.version_max = SSL_PROTOCOL_VERSION_TLS1;
   }
@@ skipping 102 matching lines @@
   StaticSocketDataProvider data(mock_reads, arraysize(mock_reads), NULL, 0);
   mock_socket_factory_.AddSocketDataProvider(&data);
 
   HttpNetworkSession session(session_params_);
   HttpNetworkTransaction trans1(DEFAULT_PRIORITY, &session);
 
   TestCompletionCallback callback;
   int rv = callback.GetResult(
       trans1.Start(GetRequestInfo("https://www.example.com/"),
                    callback.callback(), BoundNetLog()));
-  EXPECT_EQ(OK, rv);
+  EXPECT_THAT(rv, IsOk());
 
   HttpRequestHeaders headers1;
   ASSERT_TRUE(trans1.GetFullRequestHeaders(&headers1));
   std::string token_binding_header1;
   EXPECT_TRUE(headers1.GetHeader(HttpRequestHeaders::kTokenBinding,
                                  &token_binding_header1));
 
   // Send a second request and verify that the token binding header is the same
   // as in the first request.
   mock_socket_factory_.AddSSLSocketDataProvider(&ssl_data);
   StaticSocketDataProvider data2(mock_reads, arraysize(mock_reads), NULL, 0);
   mock_socket_factory_.AddSocketDataProvider(&data2);
   HttpNetworkTransaction trans2(DEFAULT_PRIORITY, &session);
 
   rv = callback.GetResult(
       trans2.Start(GetRequestInfo("https://www.example.com/"),
                    callback.callback(), BoundNetLog()));
-  EXPECT_EQ(OK, rv);
+  EXPECT_THAT(rv, IsOk());
 
   HttpRequestHeaders headers2;
   ASSERT_TRUE(trans2.GetFullRequestHeaders(&headers2));
   std::string token_binding_header2;
   EXPECT_TRUE(headers2.GetHeader(HttpRequestHeaders::kTokenBinding,
                                  &token_binding_header2));
 
   EXPECT_EQ(token_binding_header1, token_binding_header2);
 }
 
@@ skipping 13 matching lines @@
   StaticSocketDataProvider data(mock_reads, arraysize(mock_reads), NULL, 0);
   mock_socket_factory_.AddSocketDataProvider(&data);
 
   HttpNetworkSession session(session_params_);
   HttpNetworkTransaction trans(DEFAULT_PRIORITY, &session);
 
   TestCompletionCallback callback;
   int rv =
       callback.GetResult(trans.Start(GetRequestInfo("http://www.example.com/"),
                                      callback.callback(), BoundNetLog()));
-  EXPECT_EQ(OK, rv);
+  EXPECT_THAT(rv, IsOk());
 
   HttpRequestHeaders headers;
   ASSERT_TRUE(trans.GetFullRequestHeaders(&headers));
   std::string token_binding_header;
   EXPECT_FALSE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
                                  &token_binding_header));
 }
 #endif  // !defined(OS_IOS)
 
 }  // namespace net