Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: net/base/static_cookie_policy_unittest.cc

Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to contents.txt files Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/base/file_stream_unittest.cc ('k') | net/base/upload_bytes_element_reader_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/net_errors.h" 5 #include "net/base/net_errors.h"
6 #include "net/base/static_cookie_policy.h" 6 #include "net/base/static_cookie_policy.h"
7 #include "net/test/gtest_util.h"
8 #include "testing/gmock/include/gmock/gmock.h"
7 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
8 #include "url/gurl.h" 10 #include "url/gurl.h"
9 11
12 using net::test::IsOk;
13
10 namespace net { 14 namespace net {
11 15
12 class StaticCookiePolicyTest : public testing::Test { 16 class StaticCookiePolicyTest : public testing::Test {
13 public: 17 public:
14 StaticCookiePolicyTest() 18 StaticCookiePolicyTest()
15 : url_google_("http://www.google.izzle"), 19 : url_google_("http://www.google.izzle"),
16 url_google_secure_("https://www.google.izzle"), 20 url_google_secure_("https://www.google.izzle"),
17 url_google_mail_("http://mail.google.izzle"), 21 url_google_mail_("http://mail.google.izzle"),
18 url_google_analytics_("http://www.googleanalytics.izzle") { 22 url_google_analytics_("http://www.googleanalytics.izzle") {
19 } 23 }
20 void SetPolicyType(StaticCookiePolicy::Type type) { 24 void SetPolicyType(StaticCookiePolicy::Type type) {
21 policy_.set_type(type); 25 policy_.set_type(type);
22 } 26 }
23 int CanGetCookies(const GURL& url, const GURL& first_party) { 27 int CanGetCookies(const GURL& url, const GURL& first_party) {
24 return policy_.CanGetCookies(url, first_party); 28 return policy_.CanGetCookies(url, first_party);
25 } 29 }
26 int CanSetCookie(const GURL& url, const GURL& first_party) { 30 int CanSetCookie(const GURL& url, const GURL& first_party) {
27 return policy_.CanSetCookie(url, first_party); 31 return policy_.CanSetCookie(url, first_party);
28 } 32 }
29 protected: 33 protected:
30 StaticCookiePolicy policy_; 34 StaticCookiePolicy policy_;
31 GURL url_google_; 35 GURL url_google_;
32 GURL url_google_secure_; 36 GURL url_google_secure_;
33 GURL url_google_mail_; 37 GURL url_google_mail_;
34 GURL url_google_analytics_; 38 GURL url_google_analytics_;
35 }; 39 };
36 40
37 TEST_F(StaticCookiePolicyTest, DefaultPolicyTest) { 41 TEST_F(StaticCookiePolicyTest, DefaultPolicyTest) {
38 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_)); 42 EXPECT_THAT(CanGetCookies(url_google_, url_google_), IsOk());
39 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_secure_)); 43 EXPECT_THAT(CanGetCookies(url_google_, url_google_secure_), IsOk());
40 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_mail_)); 44 EXPECT_THAT(CanGetCookies(url_google_, url_google_mail_), IsOk());
41 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_analytics_)); 45 EXPECT_THAT(CanGetCookies(url_google_, url_google_analytics_), IsOk());
42 EXPECT_EQ(OK, CanGetCookies(url_google_, GURL())); 46 EXPECT_THAT(CanGetCookies(url_google_, GURL()), IsOk());
43 47
44 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_)); 48 EXPECT_THAT(CanSetCookie(url_google_, url_google_), IsOk());
45 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_secure_)); 49 EXPECT_THAT(CanSetCookie(url_google_, url_google_secure_), IsOk());
46 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_mail_)); 50 EXPECT_THAT(CanSetCookie(url_google_, url_google_mail_), IsOk());
47 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_analytics_)); 51 EXPECT_THAT(CanSetCookie(url_google_, url_google_analytics_), IsOk());
48 EXPECT_EQ(OK, CanSetCookie(url_google_, GURL())); 52 EXPECT_THAT(CanSetCookie(url_google_, GURL()), IsOk());
49 } 53 }
50 54
51 TEST_F(StaticCookiePolicyTest, AllowAllCookiesTest) { 55 TEST_F(StaticCookiePolicyTest, AllowAllCookiesTest) {
52 SetPolicyType(StaticCookiePolicy::ALLOW_ALL_COOKIES); 56 SetPolicyType(StaticCookiePolicy::ALLOW_ALL_COOKIES);
53 57
54 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_)); 58 EXPECT_THAT(CanGetCookies(url_google_, url_google_), IsOk());
55 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_secure_)); 59 EXPECT_THAT(CanGetCookies(url_google_, url_google_secure_), IsOk());
56 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_mail_)); 60 EXPECT_THAT(CanGetCookies(url_google_, url_google_mail_), IsOk());
57 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_analytics_)); 61 EXPECT_THAT(CanGetCookies(url_google_, url_google_analytics_), IsOk());
58 EXPECT_EQ(OK, CanGetCookies(url_google_, GURL())); 62 EXPECT_THAT(CanGetCookies(url_google_, GURL()), IsOk());
59 63
60 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_)); 64 EXPECT_THAT(CanSetCookie(url_google_, url_google_), IsOk());
61 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_secure_)); 65 EXPECT_THAT(CanSetCookie(url_google_, url_google_secure_), IsOk());
62 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_mail_)); 66 EXPECT_THAT(CanSetCookie(url_google_, url_google_mail_), IsOk());
63 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_analytics_)); 67 EXPECT_THAT(CanSetCookie(url_google_, url_google_analytics_), IsOk());
64 EXPECT_EQ(OK, CanSetCookie(url_google_, GURL())); 68 EXPECT_THAT(CanSetCookie(url_google_, GURL()), IsOk());
65 } 69 }
66 70
67 TEST_F(StaticCookiePolicyTest, BlockAllThirdPartyCookiesTest) { 71 TEST_F(StaticCookiePolicyTest, BlockAllThirdPartyCookiesTest) {
68 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES); 72 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES);
69 73
70 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_)); 74 EXPECT_THAT(CanGetCookies(url_google_, url_google_), IsOk());
71 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_secure_)); 75 EXPECT_THAT(CanGetCookies(url_google_, url_google_secure_), IsOk());
72 EXPECT_EQ(OK, CanGetCookies(url_google_, url_google_mail_)); 76 EXPECT_THAT(CanGetCookies(url_google_, url_google_mail_), IsOk());
73 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_analytics_)); 77 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_analytics_));
74 EXPECT_EQ(OK, CanGetCookies(url_google_, GURL())); 78 EXPECT_THAT(CanGetCookies(url_google_, GURL()), IsOk());
75 79
76 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_)); 80 EXPECT_THAT(CanSetCookie(url_google_, url_google_), IsOk());
77 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_secure_)); 81 EXPECT_THAT(CanSetCookie(url_google_, url_google_secure_), IsOk());
78 EXPECT_EQ(OK, CanSetCookie(url_google_, url_google_mail_)); 82 EXPECT_THAT(CanSetCookie(url_google_, url_google_mail_), IsOk());
79 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_analytics_)); 83 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_analytics_));
80 EXPECT_EQ(OK, CanSetCookie(url_google_, GURL())); 84 EXPECT_THAT(CanSetCookie(url_google_, GURL()), IsOk());
81 } 85 }
82 86
83 TEST_F(StaticCookiePolicyTest, BlockAllCookiesTest) { 87 TEST_F(StaticCookiePolicyTest, BlockAllCookiesTest) {
84 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_COOKIES); 88 SetPolicyType(StaticCookiePolicy::BLOCK_ALL_COOKIES);
85 89
86 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_)); 90 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_));
87 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_secure_)); 91 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_secure_));
88 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_mail_)); 92 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_mail_));
89 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_analytics_)); 93 EXPECT_NE(OK, CanGetCookies(url_google_, url_google_analytics_));
90 EXPECT_NE(OK, CanGetCookies(url_google_, GURL())); 94 EXPECT_NE(OK, CanGetCookies(url_google_, GURL()));
91 95
92 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_)); 96 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_));
93 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_secure_)); 97 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_secure_));
94 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_mail_)); 98 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_mail_));
95 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_analytics_)); 99 EXPECT_NE(OK, CanSetCookie(url_google_, url_google_analytics_));
96 EXPECT_NE(OK, CanSetCookie(url_google_, GURL())); 100 EXPECT_NE(OK, CanSetCookie(url_google_, GURL()));
97 } 101 }
98 102
99 } // namespace net 103 } // namespace net
OLDNEW
« no previous file with comments | « net/base/file_stream_unittest.cc ('k') | net/base/upload_bytes_element_reader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698