Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: net/websockets/websocket_errors_test.cc

Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to contents.txt files Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/websockets/websocket_errors.h" 5 #include "net/websockets/websocket_errors.h"
6 6
7 #include "net/base/net_errors.h" 7 #include "net/base/net_errors.h"
8 #include "net/test/gtest_util.h"
9 #include "testing/gmock/include/gmock/gmock.h"
8 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
9 11
12 using net::test::IsOk;
13
10 namespace net { 14 namespace net {
11 namespace { 15 namespace {
12 16
13 // Confirm that the principle classes of errors are converted correctly. We 17 // Confirm that the principle classes of errors are converted correctly. We
14 // don't exhaustively test every error code, as it would be long, repetitive, 18 // don't exhaustively test every error code, as it would be long, repetitive,
15 // and add little value. 19 // and add little value.
16 TEST(WebSocketErrorToNetErrorTest, ResultsAreCorrect) { 20 TEST(WebSocketErrorToNetErrorTest, ResultsAreCorrect) {
17 EXPECT_EQ(OK, WebSocketErrorToNetError(kWebSocketNormalClosure)); 21 EXPECT_THAT(WebSocketErrorToNetError(kWebSocketNormalClosure), IsOk());
18 EXPECT_EQ(ERR_WS_PROTOCOL_ERROR, 22 EXPECT_EQ(ERR_WS_PROTOCOL_ERROR,
19 WebSocketErrorToNetError(kWebSocketErrorProtocolError)); 23 WebSocketErrorToNetError(kWebSocketErrorProtocolError));
20 EXPECT_EQ(ERR_MSG_TOO_BIG, 24 EXPECT_EQ(ERR_MSG_TOO_BIG,
21 WebSocketErrorToNetError(kWebSocketErrorMessageTooBig)); 25 WebSocketErrorToNetError(kWebSocketErrorMessageTooBig));
22 EXPECT_EQ(ERR_CONNECTION_CLOSED, 26 EXPECT_EQ(ERR_CONNECTION_CLOSED,
23 WebSocketErrorToNetError(kWebSocketErrorNoStatusReceived)); 27 WebSocketErrorToNetError(kWebSocketErrorNoStatusReceived));
24 EXPECT_EQ(ERR_SSL_PROTOCOL_ERROR, 28 EXPECT_EQ(ERR_SSL_PROTOCOL_ERROR,
25 WebSocketErrorToNetError(kWebSocketErrorTlsHandshake)); 29 WebSocketErrorToNetError(kWebSocketErrorTlsHandshake));
26 } 30 }
27 31
28 } // namespace 32 } // namespace
29 } // namespace net 33 } // namespace net
OLDNEW
« no previous file with comments | « net/websockets/websocket_deflate_stream_test.cc ('k') | net/websockets/websocket_handshake_stream_create_helper_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698