Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, brettw, dcheng
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=brettw@chromium.org, danakj, dcheng BUG=554600 Committed: https://crrev.com/238f0a029f813ddc3c5a3438d8896a01cf1c5aaf Cr-Commit-Position: refs/heads/master@{#405292}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -39 lines) Patch
M tools/gn/builder.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/command_ls.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_refs.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/commands.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/function_get_target_outputs.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/header_checker.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/input_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_toolchain_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/parse_tree_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/scope.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/target.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/trace.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/xcode_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:39:16 UTC) #1
dcheng
lgtm
4 years, 5 months ago (2016-07-01 02:16:23 UTC) #2
brettw
lgtm
4 years, 5 months ago (2016-07-01 17:51:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105553005/20001
4 years, 5 months ago (2016-07-13 20:06:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 21:30:23 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 21:30:56 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:32:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/238f0a029f813ddc3c5a3438d8896a01cf1c5aaf
Cr-Commit-Position: refs/heads/master@{#405292}

Powered by Google App Engine
This is Rietveld 408576698