tools/gn/ninja_toolchain_writer.cc - Issue 2105553005: tools/gn: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_toolchain_writer.cc

diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc

index 1deff58eb2c28cb7efcd576f2c304c757038a6b5..9b699b8b70766ad02cf77dcdc3b9380636ec0e7d 100644

--- a/tools/gn/ninja_toolchain_writer.cc

+++ b/tools/gn/ninja_toolchain_writer.cc

@@ -136,7 +136,7 @@ void NinjaToolchainWriter::WriteRulePattern(const char* name,

void NinjaToolchainWriter::WriteSubninjas() {

// Write subninja commands for each generated target.

- for (const auto& target : targets_) {

+ for (auto* target : targets_) {

OutputFile ninja_file(target->settings()->build_settings(),

GetNinjaFileForTarget(target));

out_ << "subninja ";

« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/ninja_writer.cc » ('j') | no next file with comments »