Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: tools/gn/target.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/scope.cc ('k') | tools/gn/trace.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 85955a7168fb371ffea80321bcf8c6c777d4e597..27d91ec80bf47068203234cf6f0344b910263167 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -128,7 +128,7 @@ bool EnsureFileIsGeneratedByDependency(const Target* target,
return true; // Found a path.
}
if (target->output_type() == Target::CREATE_BUNDLE) {
- for (const auto& dep : target->bundle_data().bundle_deps()) {
+ for (auto* dep : target->bundle_data().bundle_deps()) {
if (EnsureFileIsGeneratedByDependency(dep, file, false,
consider_object_files,
check_data_deps, seen_targets))
@@ -524,7 +524,7 @@ void Target::PullRecursiveBundleData() {
bundle_data_.AddBundleData(pair.ptr);
// Recursive bundle_data informations from all dependencies.
- for (const auto& target : pair.ptr->bundle_data().bundle_deps())
+ for (auto* target : pair.ptr->bundle_data().bundle_deps())
bundle_data_.AddBundleData(target);
}
« no previous file with comments | « tools/gn/scope.cc ('k') | tools/gn/trace.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698