tools/gn/ninja_writer.cc - Issue 2105553005: tools/gn: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_writer.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_writer.cc

diff --git a/tools/gn/ninja_writer.cc b/tools/gn/ninja_writer.cc

index 7d26f484730c05146c603d9b4e8a9e59ae8aa1ef..22a97ec4205fcaee353b25953fe134fdc0f28945 100644

--- a/tools/gn/ninja_writer.cc

+++ b/tools/gn/ninja_writer.cc

@@ -58,7 +58,7 @@ bool NinjaWriter::WriteToolchains(std::vector<const Settings*>* all_settings,

CategorizedMap categorized;

std::vector<const BuilderRecord*> all_records = builder_->GetAllRecords();

- for (const auto& all_record : all_records) {

+ for (auto* all_record : all_records) {

if (all_record->type() == BuilderRecord::ITEM_TARGET &&

all_record->should_generate()) {

categorized[all_record->label().GetToolchainLabel()].push_back(

« no previous file with comments | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/parse_tree_unittest.cc » ('j') | no next file with comments »