Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: tools/gn/builder.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/command_ls.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/builder.cc
diff --git a/tools/gn/builder.cc b/tools/gn/builder.cc
index 036d3902c707ff2e183059d94bd223553d8866b8..93aec154fa6f4d7d2d091ae8fce324d70ffcfc02 100644
--- a/tools/gn/builder.cc
+++ b/tools/gn/builder.cc
@@ -33,7 +33,7 @@ typedef BuilderRecord::BuilderRecordSet BuilderRecordSet;
bool RecursiveFindCycle(const BuilderRecord* search_in,
std::vector<const BuilderRecord*>* path) {
path->push_back(search_in);
- for (const auto& cur : search_in->unresolved_deps()) {
+ for (auto* cur : search_in->unresolved_deps()) {
std::vector<const BuilderRecord*>::iterator found =
std::find(path->begin(), path->end(), cur);
if (found != path->end()) {
@@ -182,7 +182,7 @@ bool Builder::CheckForBadItems(Err* err) const {
bad_records.push_back(src);
// Check dependencies.
- for (const auto& dest : src->unresolved_deps()) {
+ for (auto* dest : src->unresolved_deps()) {
if (!dest->item()) {
depstring += src->label().GetUserVisibleName(true) +
"\n needs " + dest->label().GetUserVisibleName(true) + "\n";
@@ -204,7 +204,7 @@ bool Builder::CheckForBadItems(Err* err) const {
// Something's very wrong, just dump out the bad nodes.
depstring = "I have no idea what went wrong, but these are unresolved, "
"possibly due to an\ninternal error:";
- for (const auto& bad_record : bad_records) {
+ for (auto* bad_record : bad_records) {
depstring += "\n\"" +
bad_record->label().GetUserVisibleName(false) + "\"";
}
@@ -252,7 +252,7 @@ bool Builder::ConfigDefined(BuilderRecord* record, Err* err) {
// anything they depend on is actually written, the "generate" flag isn't
// relevant and means extra book keeping. Just force load any deps of this
// config.
- for (const auto& cur : record->all_deps())
+ for (auto* cur : record->all_deps())
ScheduleItemLoadIfNecessary(cur);
return true;
@@ -408,7 +408,7 @@ void Builder::RecursiveSetShouldGenerate(BuilderRecord* record,
return; // Already set.
record->set_should_generate(true);
- for (const auto& cur : record->all_deps()) {
+ for (auto* cur : record->all_deps()) {
if (!cur->should_generate()) {
ScheduleItemLoadIfNecessary(cur);
RecursiveSetShouldGenerate(cur, false);
« no previous file with comments | « no previous file | tools/gn/command_ls.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698