tools/gn/ninja_target_writer.cc - Issue 2105553005: tools/gn: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index 7843d757a7161bdebf1fcf9a81387f68c58efc1f..69e9d9051d2b8070f235dbfdb99415bdc1ecf591 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -255,7 +255,7 @@ OutputFile NinjaTargetWriter::WriteInputDepsStampAndGetDep(

std::sort(

input_deps_targets.begin(), input_deps_targets.end(),

[](const Target* a, const Target* b) { return a->label() < b->label(); });

- for (const auto& dep : input_deps_targets) {

+ for (auto* dep : input_deps_targets) {

DCHECK(!dep->dependency_output_file().value().empty());

out_ << " ";

path_output_.WriteFile(out_, dep->dependency_output_file());

« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »