Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 9b0458ae787148911f7f5103b29e5c62edbef19c..129ddb1b849dfbe5cccb2bd4648356ce7b60f707 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -948,7 +948,7 @@ void NinjaBinaryTargetWriter::WriteSourceSetStamp(
DCHECK(extra_object_files.empty());
std::vector<OutputFile> order_only_deps;
- for (const auto& dep : non_linkable_deps)
+ for (auto* dep : non_linkable_deps)
order_only_deps.push_back(dep->dependency_output_file());
WriteStampForTarget(object_files, order_only_deps);
@@ -965,8 +965,7 @@ void NinjaBinaryTargetWriter::GetDeps(
}
// Inherited libraries.
- for (const auto& inherited_target :
- target_->inherited_libraries().GetOrdered()) {
+ for (auto* inherited_target : target_->inherited_libraries().GetOrdered()) {
ClassifyDependency(inherited_target, extra_object_files,
linkable_deps, non_linkable_deps);
}
@@ -1029,7 +1028,7 @@ void NinjaBinaryTargetWriter::WriteOrderOnlyDependencies(
out_ << " ||";
// Non-linkable targets.
- for (const auto& non_linkable_dep : non_linkable_deps) {
+ for (auto* non_linkable_dep : non_linkable_deps) {
out_ << " ";
path_output_.WriteFile(out_, non_linkable_dep->dependency_output_file());
}
« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698