tools/gn/command_ls.cc - Issue 2105553005: tools/gn: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_ls.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_ls.cc

diff --git a/tools/gn/command_ls.cc b/tools/gn/command_ls.cc

index c9b9672cf80aabffc906b3670e2d0bfd8f891d6c..f53a7272a32ae2583fcaf3cef3220cf14821b104 100644

--- a/tools/gn/command_ls.cc

+++ b/tools/gn/command_ls.cc

@@ -100,7 +100,7 @@ int RunLs(const std::vector<std::string>& args) {

matches = setup->builder()->GetAllResolvedTargets();

} else {

// List all resolved targets in the default toolchain.

- for (const auto& target : setup->builder()->GetAllResolvedTargets()) {

+ for (auto* target : setup->builder()->GetAllResolvedTargets()) {

if (target->settings()->is_default())

matches.push_back(target);

}

« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/command_refs.cc » ('j') | no next file with comments »