tools/gn/parser.cc - Issue 2105553005: tools/gn: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/parser.cc

Issue 2105553005: tools/gn: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/parser.cc

diff --git a/tools/gn/parser.cc b/tools/gn/parser.cc

index 977ddad6e7b27d592bc1c09a574a8ebf9fdaa42f..7e5886f8950b3d4b4466aa34e966658ca05779ed 100644

--- a/tools/gn/parser.cc

+++ b/tools/gn/parser.cc

@@ -711,7 +711,7 @@ void Parser::AssignComments(ParseNode* file) {

// Assign line comments to syntax immediately following.

int cur_comment = 0;

- for (const auto& node : pre) {

+ for (auto* node : pre) {

const Location& start = node->GetRange().begin();

while (cur_comment < static_cast<int>(line_comment_tokens_.size())) {

if (start.byte() >= line_comment_tokens_[cur_comment].location().byte()) {

« no previous file with comments | « tools/gn/parse_tree_unittest.cc ('k') | tools/gn/scope.cc » ('j') | no next file with comments »