Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SpdyHeaderBlock non-copyable. Also change all remaining invocations of the copy constructor or copy assignment operator to move or explicit copy. This CL lands server change 126070406 by bnc. BUG=488484, 621905 Committed: https://crrev.com/94893a702549bf5d2e1f7c3cfafc904206f1cb57 Cr-Commit-Position: refs/heads/master@{#403165}

Patch Set 1 #

Patch Set 2 : iOS fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -345 lines) Patch
M components/cronet/ios/test/quic_test_server.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/bidirectional_stream_quic_impl_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M net/quic/quic_chromium_client_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_stream.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 12 chunks +40 lines, -22 lines 0 comments Download
M net/quic/quic_client_promised_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_client_promised_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 9 chunks +20 lines, -17 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 8 chunks +11 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +17 lines, -2 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/spdy/hpack/hpack_decoder_test.cc View 14 chunks +22 lines, -25 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 13 chunks +8 lines, -13 lines 0 comments Download
M net/spdy/spdy_header_block.h View 2 chunks +5 lines, -2 lines 0 comments Download
M net/spdy/spdy_header_block.cc View 3 chunks +8 lines, -15 lines 0 comments Download
M net/spdy/spdy_header_block_test.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 10 chunks +63 lines, -41 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 5 chunks +11 lines, -9 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 9 chunks +31 lines, -29 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 5 chunks +36 lines, -18 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 17 chunks +55 lines, -43 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 5 months ago (2016-06-29 17:37:44 UTC) #2
Ryan Hamilton
lgtm Thanks for doing this!
4 years, 5 months ago (2016-06-29 19:54:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102253003/20001
4 years, 5 months ago (2016-06-30 03:30:25 UTC) #5
Bence
kapishnikov:PTAL at components/cronet/. Thank you.
4 years, 5 months ago (2016-06-30 03:32:35 UTC) #8
kapishnikov
components/cronet - LGTM
4 years, 5 months ago (2016-06-30 03:42:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102253003/20001
4 years, 5 months ago (2016-06-30 13:22:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 13:45:44 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 13:45:47 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 13:48:29 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/94893a702549bf5d2e1f7c3cfafc904206f1cb57
Cr-Commit-Position: refs/heads/master@{#403165}

Powered by Google App Engine
This is Rietveld 408576698