Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: net/quic/bidirectional_stream_quic_impl_unittest.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/quic/quic_chromium_client_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/bidirectional_stream_quic_impl_unittest.cc
diff --git a/net/quic/bidirectional_stream_quic_impl_unittest.cc b/net/quic/bidirectional_stream_quic_impl_unittest.cc
index f7a512314eab6ef4e44b679a87aa2f4f42ce5e7d..abad19b225b98af0b5e520bd61ac08fd1c61bf9f 100644
--- a/net/quic/bidirectional_stream_quic_impl_unittest.cc
+++ b/net/quic/bidirectional_stream_quic_impl_unittest.cc
@@ -90,7 +90,7 @@ class TestDelegateBase : public BidirectionalStreamImpl::Delegate {
CHECK(!on_failed_called_);
CHECK(!not_expect_callback_);
- response_headers_ = response_headers;
+ response_headers_ = response_headers.Clone();
loop_->Quit();
}
@@ -117,7 +117,7 @@ class TestDelegateBase : public BidirectionalStreamImpl::Delegate {
CHECK(!on_failed_called_);
CHECK(!not_expect_callback_);
- trailers_ = trailers;
+ trailers_ = trailers.Clone();
loop_->Quit();
}
@@ -493,11 +493,11 @@ class BidirectionalStreamQuicImplTest
std::unique_ptr<QuicReceivedPacket> ConstructResponseTrailersPacket(
QuicPacketNumber packet_number,
bool fin,
- const SpdyHeaderBlock& trailers,
+ SpdyHeaderBlock trailers,
size_t* spdy_headers_frame_length,
QuicStreamOffset* offset) {
return server_maker_.MakeResponseHeadersPacket(
- packet_number, stream_id_, !kIncludeVersion, fin, trailers,
+ packet_number, stream_id_, !kIncludeVersion, fin, std::move(trailers),
spdy_headers_frame_length, offset);
}
@@ -659,7 +659,7 @@ TEST_P(BidirectionalStreamQuicImplTest, GetRequest) {
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
EXPECT_EQ(OK, cb2.WaitForResult());
@@ -783,7 +783,7 @@ TEST_P(BidirectionalStreamQuicImplTest, CoalesceDataBuffersNotHeadersFrame) {
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
trailers.erase(kFinalOffsetHeaderKey);
@@ -879,7 +879,7 @@ TEST_P(BidirectionalStreamQuicImplTest,
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
trailers.erase(kFinalOffsetHeaderKey);
@@ -982,7 +982,7 @@ TEST_P(BidirectionalStreamQuicImplTest,
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
trailers.erase(kFinalOffsetHeaderKey);
@@ -1062,7 +1062,7 @@ TEST_P(BidirectionalStreamQuicImplTest, PostRequest) {
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
trailers.erase(kFinalOffsetHeaderKey);
@@ -1139,7 +1139,7 @@ TEST_P(BidirectionalStreamQuicImplTest, PutRequest) {
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
trailers.erase(kFinalOffsetHeaderKey);
@@ -1658,7 +1658,7 @@ TEST_P(BidirectionalStreamQuicImplTest, DeleteStreamDuringOnTrailersReceived) {
trailers[kFinalOffsetHeaderKey] = base::IntToString(strlen(kResponseBody));
// Server sends trailers.
ProcessPacket(ConstructResponseTrailersPacket(
- 4, kFin, trailers, &spdy_trailers_frame_length, &offset));
+ 4, kFin, trailers.Clone(), &spdy_trailers_frame_length, &offset));
delegate->WaitUntilNextCallback(); // OnTrailersReceived
trailers.erase(kFinalOffsetHeaderKey);
« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/quic/quic_chromium_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698