Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/bidirectional_stream_spdy_impl_unittest.cc ('k') | net/spdy/hpack/hpack_decoder_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer_unittest.cc
diff --git a/net/spdy/buffered_spdy_framer_unittest.cc b/net/spdy/buffered_spdy_framer_unittest.cc
index f70a6bcc50a6b5b07a5e228af66f66dbac8e4ffe..3e96481df2338836ca6a64d4606bb6bae5d54dee 100644
--- a/net/spdy/buffered_spdy_framer_unittest.cc
+++ b/net/spdy/buffered_spdy_framer_unittest.cc
@@ -50,7 +50,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
header_stream_id_ = stream_id;
EXPECT_NE(header_stream_id_, SpdyFramer::kInvalidStream);
syn_frame_count_++;
- headers_ = headers;
+ headers_ = headers.Clone();
}
void OnSynReply(SpdyStreamId stream_id,
@@ -59,7 +59,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
header_stream_id_ = stream_id;
EXPECT_NE(header_stream_id_, SpdyFramer::kInvalidStream);
syn_reply_frame_count_++;
- headers_ = headers;
+ headers_ = headers.Clone();
}
void OnHeaders(SpdyStreamId stream_id,
@@ -72,7 +72,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
header_stream_id_ = stream_id;
EXPECT_NE(header_stream_id_, SpdyFramer::kInvalidStream);
headers_frame_count_++;
- headers_ = headers;
+ headers_ = headers.Clone();
}
void OnDataFrameHeader(SpdyStreamId stream_id,
@@ -132,7 +132,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
push_promise_frame_count_++;
promised_stream_id_ = promised_stream_id;
EXPECT_NE(promised_stream_id_, SpdyFramer::kInvalidStream);
- headers_ = headers;
+ headers_ = headers.Clone();
}
void OnAltSvc(SpdyStreamId stream_id,
@@ -244,7 +244,7 @@ TEST_P(BufferedSpdyFramerTest, ReadSynStreamHeaderBlock) {
framer.CreateSynStream(1, // stream_id
0, // associated_stream_id
1, // priority
- CONTROL_FLAG_NONE, headers));
+ CONTROL_FLAG_NONE, headers.Clone()));
EXPECT_TRUE(control_frame.get() != NULL);
TestBufferedSpdyVisitor visitor(spdy_version());
@@ -295,7 +295,7 @@ TEST_P(BufferedSpdyFramerTest, ReadSynReplyHeaderBlock) {
BufferedSpdyFramer framer(spdy_version());
std::unique_ptr<SpdySerializedFrame> control_frame(
framer.CreateSynReply(1, // stream_id
- CONTROL_FLAG_NONE, headers));
+ CONTROL_FLAG_NONE, headers.Clone()));
EXPECT_TRUE(control_frame.get() != NULL);
TestBufferedSpdyVisitor visitor(spdy_version());
@@ -324,7 +324,7 @@ TEST_P(BufferedSpdyFramerTest, ReadHeadersHeaderBlock) {
framer.CreateHeaders(1, // stream_id
CONTROL_FLAG_NONE,
255, // weight
- headers));
+ headers.Clone()));
EXPECT_TRUE(control_frame.get() != NULL);
TestBufferedSpdyVisitor visitor(spdy_version());
@@ -347,7 +347,7 @@ TEST_P(BufferedSpdyFramerTest, ReadPushPromiseHeaderBlock) {
headers["gamma"] = "delta";
BufferedSpdyFramer framer(spdy_version());
std::unique_ptr<SpdySerializedFrame> control_frame(
- framer.CreatePushPromise(1, 2, headers));
+ framer.CreatePushPromise(1, 2, headers.Clone()));
EXPECT_TRUE(control_frame.get() != NULL);
TestBufferedSpdyVisitor visitor(spdy_version());
« no previous file with comments | « net/spdy/bidirectional_stream_spdy_impl_unittest.cc ('k') | net/spdy/hpack/hpack_decoder_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698