Make SpdyHeaderBlock non-copyable.

net/tools/quic/quic_simple_server_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/quic_simple_server_session.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 59 matching lines @@
     QuicStreamId original_stream_id,
     const SpdyHeaderBlock& original_request_headers) {
   if (!server_push_enabled()) {
     return;
   }
 
   for (QuicInMemoryCache::ServerPushInfo resource : resources) {
     SpdyHeaderBlock headers = SynthesizePushRequestHeaders(
         request_url, resource, original_request_headers);
     highest_promised_stream_id_ += 2;
-    SendPushPromise(original_stream_id, highest_promised_stream_id_, headers);
+    SendPushPromise(original_stream_id, highest_promised_stream_id_,
+                    headers.Clone());
     promised_streams_.push_back(PromisedStreamInfo(
         std::move(headers), highest_promised_stream_id_, resource.priority));
   }
 
   // Procese promised push request as many as possible.
   HandlePromisedPushRequests();
 }
 
 QuicSpdyStream* QuicSimpleServerSession::CreateIncomingDynamicStream(
     QuicStreamId id) {
@@ skipping 53 matching lines @@
   }
 }
 
 SpdyHeaderBlock QuicSimpleServerSession::SynthesizePushRequestHeaders(
     string request_url,
     QuicInMemoryCache::ServerPushInfo resource,
     const SpdyHeaderBlock& original_request_headers) {
   GURL push_request_url = resource.request_url;
   string path = push_request_url.path();
 
-  SpdyHeaderBlock spdy_headers = original_request_headers;
+  SpdyHeaderBlock spdy_headers = original_request_headers.Clone();
   // :authority could be different from original request.
   spdy_headers.ReplaceOrAppendHeader(":authority", push_request_url.host());
   spdy_headers.ReplaceOrAppendHeader(":path", path);
   // Push request always use GET.
   spdy_headers.ReplaceOrAppendHeader(":method", "GET");
   spdy_headers.ReplaceOrAppendHeader("referer", request_url);
   spdy_headers.ReplaceOrAppendHeader(":scheme", push_request_url.scheme());
   // It is not possible to push a response to a request that includes a request
   // body.
   spdy_headers.ReplaceOrAppendHeader("content-length", "0");
   // Remove "host" field as push request is a directly generated HTTP2 request
   // which should use ":authority" instead of "host".
   spdy_headers.erase("host");
   return spdy_headers;
 }
 
 void QuicSimpleServerSession::SendPushPromise(QuicStreamId original_stream_id,
                                               QuicStreamId promised_stream_id,
                                               SpdyHeaderBlock headers) {
   DVLOG(1) << "stream " << original_stream_id
            << " send PUSH_PROMISE for promised stream " << promised_stream_id;
   headers_stream()->WritePushPromise(original_stream_id, promised_stream_id,
                                      std::move(headers), nullptr);
 }
 
 void QuicSimpleServerSession::HandlePromisedPushRequests() {
   while (!promised_streams_.empty() && ShouldCreateOutgoingDynamicStream()) {
-    const PromisedStreamInfo& promised_info = promised_streams_.front();
+    PromisedStreamInfo& promised_info = promised_streams_.front();
     DCHECK_EQ(next_outgoing_stream_id(), promised_info.stream_id);
 
     if (promised_info.is_cancelled) {
       // This stream has been reset by client. Skip this stream id.
       promised_streams_.pop_front();
       GetNextOutgoingStreamId();
       return;
     }
 
     QuicSimpleServerStream* promised_stream =
         static_cast<QuicSimpleServerStream*>(
             CreateOutgoingDynamicStream(promised_info.priority));
     DCHECK(promised_stream != nullptr);
     DCHECK_EQ(promised_info.stream_id, promised_stream->id());
     DVLOG(1) << "created server push stream " << promised_stream->id();
 
-    const SpdyHeaderBlock request_headers(promised_info.request_headers);
+    SpdyHeaderBlock request_headers(std::move(promised_info.request_headers));
 
     promised_streams_.pop_front();
-    promised_stream->PushResponse(request_headers);
+    promised_stream->PushResponse(std::move(request_headers));
   }
 }
 
 }  // namespace net