net/quic/quic_http_stream_test.cc - Issue 2102253003: Make SpdyHeaderBlock non-copyable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_http_stream_test.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS fix. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_http_stream_test.cc

diff --git a/net/quic/quic_http_stream_test.cc b/net/quic/quic_http_stream_test.cc

index c665be7b61e90b05da6fee0067b4b04b56e83553..26f16eef7112efcbfd011fd60a244cc59d19216c 100644

--- a/net/quic/quic_http_stream_test.cc

+++ b/net/quic/quic_http_stream_test.cc

@@ -1368,7 +1368,7 @@ TEST_P(QuicHttpStreamTest, ServerPushGetRequest) {

callback_.callback()));

// Receive the promised response headers.

- response_headers_ = promised_response_;

+ response_headers_ = promised_response_.Clone();

size_t spdy_response_headers_frame_length;

ProcessPacket(InnerConstructResponseHeadersPacket(

1, promise_id_, false, &spdy_response_headers_frame_length));

@@ -1438,7 +1438,7 @@ TEST_P(QuicHttpStreamTest, ServerPushGetRequestSlowResponse) {

headers_, &response_, callback_.callback()));

// Receive the promised response headers.

- response_headers_ = promised_response_;

+ response_headers_ = promised_response_.Clone();

size_t spdy_response_headers_frame_length;

ProcessPacket(InnerConstructResponseHeadersPacket(

1, promise_id_, false, &spdy_response_headers_frame_length));

@@ -1511,7 +1511,7 @@ TEST_P(QuicHttpStreamTest, ServerPushCrossOriginOK) {

callback_.callback()));

// Receive the promised response headers.

- response_headers_ = promised_response_;

+ response_headers_ = promised_response_.Clone();

size_t spdy_response_headers_frame_length;

ProcessPacket(InnerConstructResponseHeadersPacket(

1, promise_id_, false, &spdy_response_headers_frame_length));

@@ -1613,7 +1613,7 @@ TEST_P(QuicHttpStreamTest, ServerPushVaryCheckOK) {

// Receive the promised response headers.

promised_response_["vary"] = "accept-encoding";

- response_headers_ = promised_response_;

+ response_headers_ = promised_response_.Clone();

size_t spdy_response_headers_frame_length;

ProcessPacket(InnerConstructResponseHeadersPacket(

1, promise_id_, false, &spdy_response_headers_frame_length));

@@ -1703,7 +1703,7 @@ TEST_P(QuicHttpStreamTest, ServerPushVaryCheckFail) {

// Receive the promised response headers.

promised_response_["vary"] = "accept-encoding";

- response_headers_ = promised_response_;

+ response_headers_ = promised_response_.Clone();

size_t spdy_response_headers_frame_length;

ProcessPacket(InnerConstructResponseHeadersPacket(

1, promise_id_, false, &spdy_response_headers_frame_length));

« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »