Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session_unittest.cc
diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc
index e3a10bd5d772368aa5a4c702818f9af400fcb531..1aafe5ef60e565aebbc96c7053d25db9a3d59915 100644
--- a/net/spdy/spdy_session_unittest.cc
+++ b/net/spdy/spdy_session_unittest.cc
@@ -412,7 +412,8 @@ TEST_P(SpdySessionTest, GoAwayWithActiveStreams) {
std::unique_ptr<SpdyHeaderBlock> headers(
new SpdyHeaderBlock(spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)));
- std::unique_ptr<SpdyHeaderBlock> headers2(new SpdyHeaderBlock(*headers));
+ std::unique_ptr<SpdyHeaderBlock> headers2(
+ new SpdyHeaderBlock(headers->Clone()));
spdy_stream1->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND);
EXPECT_TRUE(spdy_stream1->HasUrlFromHeaders());
@@ -551,7 +552,8 @@ TEST_P(SpdySessionTest, GoAwayTwice) {
std::unique_ptr<SpdyHeaderBlock> headers(
new SpdyHeaderBlock(spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)));
- std::unique_ptr<SpdyHeaderBlock> headers2(new SpdyHeaderBlock(*headers));
+ std::unique_ptr<SpdyHeaderBlock> headers2(
+ new SpdyHeaderBlock(headers->Clone()));
spdy_stream1->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND);
EXPECT_TRUE(spdy_stream1->HasUrlFromHeaders());
@@ -625,7 +627,8 @@ TEST_P(SpdySessionTest, GoAwayWithActiveStreamsThenClose) {
std::unique_ptr<SpdyHeaderBlock> headers(
new SpdyHeaderBlock(spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)));
- std::unique_ptr<SpdyHeaderBlock> headers2(new SpdyHeaderBlock(*headers));
+ std::unique_ptr<SpdyHeaderBlock> headers2(
+ new SpdyHeaderBlock(headers->Clone()));
spdy_stream1->SendRequestHeaders(std::move(headers), NO_MORE_DATA_TO_SEND);
EXPECT_TRUE(spdy_stream1->HasUrlFromHeaders());
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698